Skip to content

Conversation

@sot176
Copy link
Contributor

@sot176 sot176 commented Feb 17, 2025

In reference to issue #78 , I have added nr_channels to my dataloader and modified my model to support any input size.

@Seilmast
Copy link
Collaborator

Is this still meant to be a draft?
Just checking as I personally didn't realise the PM might get added as a draft automatically

@sot176 sot176 marked this pull request as ready for review February 17, 2025 11:13
@sot176
Copy link
Contributor Author

sot176 commented Feb 17, 2025

I changed it now to a normal PR :) I was still checking some thing but it should be fine now

Copy link
Collaborator

@Seilmast Seilmast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Seilmast Seilmast merged commit c29b585 into main Feb 17, 2025
3 of 4 checks passed
@Seilmast Seilmast deleted the solveig-develope branch February 17, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants