Fix bug where usps test weren't able to download usps data #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I get only OK tests locally, but I see that github actions fail on some USPS data. Will this pull request fix this? |
Contributor
Author
|
Yeah, I think I fixed it now. It was most likely due to the directory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a bug where if
Data/usps.h5did not already exist,tests/test_dataloader.pywere for some reason not able to download the data correctly.I suspect this could be due to
TemporaryDirectorynot being able to write to the/tmpdirectory in the container, so this draft PR is to see if adding `TemporaryDirectory(dir="Data") fixes this as the container has write permissions here anyways... 🤞🏻