feat: add event handling capabilities to SurfCoreApi
#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced methods `registerListener`, `fireEvent`, and `subscribe` in `SurfCoreApi`. - Added `surf-event-util` with inline utility for event subscriptions. - Updated `SurfCoreApiImpl` to integrate with `SurfEventBus` for event handling. - Bumped version to `1.21.11-1.1.5-SNAPSHOT`.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds public event-handling support to SurfCoreApi, allowing consumers to register annotated listeners, subscribe to events, and fire events across the network.
Changes:
- Extend
SurfCoreApiwithregisterListener,subscribe, andfireEvent. - Wire
SurfCoreApiImplto delegate event operations toSurfEventBus. - Add a typed Kotlin convenience extension for
SurfCoreApi.subscribe<T>()and bump project version.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| surf-core-core/surf-core-core-common/src/main/kotlin/dev/slne/surf/core/core/common/event/SurfEventBus.kt | Minor formatting-only change (blank line). |
| surf-core-core/surf-core-core-common/src/main/kotlin/dev/slne/surf/core/core/common/SurfCoreApiImpl.kt | Implements the new event API by delegating to surfEventBus. |
| surf-core-api/surf-core-api-common/src/main/kotlin/dev/slne/surf/core/api/common/util/surf-event-util.kt | Adds subscribe<T>() convenience extension for typed subscriptions. |
| surf-core-api/surf-core-api-common/src/main/kotlin/dev/slne/surf/core/api/common/SurfCoreApi.kt | Exposes event listener registration, subscription, and firing via the public API. |
| gradle.properties | Version bump to 1.21.11-1.1.5-SNAPSHOT. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...core/surf-core-core-common/src/main/kotlin/dev/slne/surf/core/core/common/SurfCoreApiImpl.kt
Show resolved
Hide resolved
surf-core-api/surf-core-api-common/src/main/kotlin/dev/slne/surf/core/api/common/SurfCoreApi.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registerListener,fireEvent, andsubscribeinSurfCoreApi.surf-event-utilwith inline utility for event subscriptions.SurfCoreApiImplto integrate withSurfEventBusfor event handling.1.21.11-1.1.5-SNAPSHOT.