Replace properties based system configuration values by Pa-Touche · Pull Request #13805 · SORMAS-Foundation/SORMAS-Project

Pa-Touche · 2026-01-23T12:35:23Z

What's missing to make this work:

Enable AuditLogger and make it use legacy sormas.properties file
Creates cyclic dependency that seems too difficult to fix:
Audit -> ConfigFacade -> SystemConfig -> ConfigFacade
Make descriptions work for newly added configs
EmptyString instead of null because vaading textboxes.

BackendFacadeProvider allows lazy initialization of EJBs which fixes cyclic dependencies that cannot be solved easily, mostly due to AbstractBaseEjb which also requires the ConfigFacade, but ConfigFacades requires SystemConfigurationCategoryEjb which extends AbstractBaseEjb.

Interceptors: RightsAllowed + AuditLogging occur before EJBs are fully initialized which creates a mess without lazyness.

Enhancements:

BackendFacadeProvider: create dictionary for already loaded beans to avoids multiple lookups
Add default value in UI
Add flag for "requires reboot": mostly occurs for unused properties to external systems

Approach to set the configuration values must change.

…a bit. Started refactoring Tests which is kind of complex due to usage of 'pure' java-properties to hack the config behavior at test-runtime. Requires creation of test environment for configurations to allow simple set of those values. Check if requires an intermediate layer within the ConfigFacade => SystemConfigurationValueEjb.

Tests seem to compile but do not run yet.

WARNING: requires setting some config within tests, as DB is not started and therefore not the new default configurations;

coderabbitai · 2026-01-23T12:35:30Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🔍 Trigger a full review

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch task/13278-replace_sormas-properties

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…ion script. Something still seems off: why is full systemConfigurationValueDTO passed to update the value ? Seems a bit heavy. Had to break encapsulation within SystemConfigurationValueEjb to be handle to update config values at runtime. One optimization could be to not insert everytime BUT could break if something updates through the full-fledged update path. WARN: - Container tests do not start yet - COUNTRY_EPID_PREFIX is somewhat mandatory due to the way the tests are written.

@Denyall

[ERROR] ArchitectureTest.testSystemConfigurationValueEjbAuthorization:516->assertFacadeEjbAnnotated:529->assertFacadeEjbAnnotated:568 Architecture Violation [Priority: MEDIUM] - Rule 'methods that are declared in de.symeda.sormas.backend.systemconfiguration.SystemConfigurationValueEjb and are public and are not static should be annotated with @RightsAllowed or should be annotated with @permitAll or should be annotated with @Denyall or should have name matching '^(get|count|is|does|has|validate|to|pseudonymize|convertToReferenceDto|fillOrBuild|convertToDto|fromDto|convertToDetailedReferenceDto|exists).*'' was violated (1 times): Method <de.symeda.sormas.backend.systemconfiguration.SystemConfigurationValueEjb.loadDataIfEmpty()> does not have name matching '^(get|count|is|does|has|validate|to|pseudonymize|convertToReferenceDto|fillOrBuild|convertToDto|fromDto|convertToDetailedReferenceDto|exists).*' in (SystemConfigurationValueEjb.java:147) and Method <de.symeda.sormas.backend.systemconfiguration.SystemConfigurationValueEjb.loadDataIfEmpty()> is not annotated with @Denyall in (SystemConfigurationValueEjb.java:147) and Method <de.symeda.sormas.backend.systemconfiguration.SystemConfigurationValueEjb.loadDataIfEmpty()> is not annotated with @permitAll in (SystemConfigurationValueEjb.java:147) and Method <de.symeda.sormas.backend.systemconfiguration.SystemConfigurationValueEjb.loadDataIfEmpty()> is not annotated with @RightsAllowed in (SystemConfigurationValueEjb.java:147) [ERROR] CaseClassificationLogicTest.ruleOutFalsePositivesForCholera:906 expected: <Possible case> but was: <Not yet classified> [ERROR] CaseClassificationLogicTest.testAutomaticClassificationForCholera:850 expected: <Possible case> but was: <Not yet classified> [ERROR] CaseClassificationLogicTest.testCalculationByDisease:1463 expected: <Not yet classified> but was: <Possible case> [ERROR] EventFacadeEjbTest.testValidateWithNullReportingUser:84 Unexpected exception type thrown, expected: <de.symeda.sormas.api.utils.ValidationRuntimeException> but was: <java.lang.IllegalStateException> [ERROR] ExternalEmailFacadeEjbTest.testSendBulkEmailToCasePerson:646 Wanted but not invoked: emailService.sendEmail( <any>, <any>, <any>, <any> ); -> at de.symeda.sormas.backend.common.messaging.EmailService.sendEmail(EmailService.java:69) Actually, there were zero interactions with this mock. [ERROR] ExternalEmailFacadeEjbTest.testSendBulkEmailToCasePersonAttachmentsAndTemplateDocument:742 Wanted but not invoked: emailService.sendEmail( <any>, <any>, <any>, <any> ); -> at de.symeda.sormas.backend.common.messaging.EmailService.sendEmail(EmailService.java:69) Actually, there were zero interactions with this mock. [ERROR] ExternalEmailFacadeEjbTest.testSendBulkEmailToCasePersonTemplateDocument:831 Wanted but not invoked: emailService.sendEmail( <any>, <any>, <any>, <any> ); -> at de.symeda.sormas.backend.common.messaging.EmailService.sendEmail(EmailService.java:69) Actually, there were zero interactions with this mock. [ERROR] SystemConfigurationValueFacadeEJbTest.testValidateOptionalSystemConfigurationValue:285 Expected: is <AUDIT_SOURCE_SITE> but: was "AUDIT_SOURCE_SITE" [ERROR] SystemConfigurationValueFacadeEJbTest.testValidateSystemConfigurationValueDigitsOnlyPattern:167 Expected: is <MINIMUM_ADULT_AGE> but: was "MINIMUM_ADULT_AGE" [ERROR] SystemConfigurationValueFacadeEJbTest.testValidateSystemConfigurationValueIpPattern:101 Expected: is <CENTRAL_ETCD_CA_PATH> but: was "CENTRAL_ETCD_CA_PATH" [ERROR] SystemConfigurationValueFacadeEJbTest.testValidateSystemConfigurationValuePattern:244 Expected: is <ALLOWED_FILE_EXTENSIONS> but: was "ALLOWED_FILE_EXTENSIONS" [ERROR] SystemConfigurationValueFacadeEJbTest.testValidateSystemConfigurationValuePattern:244 Expected: is <ALLOWED_FILE_EXTENSIONS> but: was "ALLOWED_FILE_EXTENSIONS" [ERROR] SystemConfigurationValueFacadeEJbTest.testValidateSystemConfigurationValuePattern:244 Expected: is <ALLOWED_FILE_EXTENSIONS> but: was "ALLOWED_FILE_EXTENSIONS" [ERROR] SystemConfigurationValueFacadeEJbTest.testValidateSystemConfigurationValuePattern:244 Expected: is <ALLOWED_FILE_EXTENSIONS> but: was "ALLOWED_FILE_EXTENSIONS" [ERROR] SystemConfigurationValueFacadeEJbTest.testValidateSystemConfigurationValuePattern:244 Expected: is <ALLOWED_FILE_EXTENSIONS> but: was "ALLOWED_FILE_EXTENSIONS" [ERROR] SystemConfigurationValueFacadeEJbTest.testValidateSystemConfigurationValuePattern:244 Expected: is <ALLOWED_FILE_EXTENSIONS> but: was "ALLOWED_FILE_EXTENSIONS" [ERROR] SystemConfigurationValueFacadeEJbTest.testValidateSystemConfigurationValuePattern:244 Expected: is <ALLOWED_FILE_EXTENSIONS> but: was "ALLOWED_FILE_EXTENSIONS" [ERROR] SystemConfigurationValueFacadeEJbTest.testValidateSystemConfigurationValuePattern:244 Expected: is <ALLOWED_FILE_EXTENSIONS> but: was "ALLOWED_FILE_EXTENSIONS" [ERROR] SystemConfigurationValueFacadeEJbTest.testValidateSystemConfigurationValuePattern:244 Expected: is <ALLOWED_FILE_EXTENSIONS> but: was "ALLOWED_FILE_EXTENSIONS" [ERROR] SystemConfigurationValueFacadeEJbTest.testValidateSystemConfigurationValuePipeSeparatedWordsPattern:201 Expected: is <AUDIT_LOGGER_CONFIG> but: was "AUDIT_LOGGER_CONFIG" [ERROR] SystemConfigurationValueFacadeEJbTest.testValidateSystemConfigurationValueUnixDirPattern:134 Expected: is <TEMP_PATH> but: was "TEMP_PATH" [ERROR] Errors: [ERROR] ActionFacadeEjbTest.testGetAllUuids:57 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ActionFacadeEjbTest.testGetEventActionList:109 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] CaseFacadeEjbPseudonymizationTest.testPseudonymizeCaseExportData:274 » IllegalState Required configuration 'COUNTRY_EPID_PREFIX' not found or invalid. Check if [ERROR] CaseFacadeEjbPseudonymizationTest.testSpecialCaseAccessOutsideJurisdiction:460 » IllegalState Required configuration 'COUNTRY_EPID_PREFIX' not found or invalid. Check if [ERROR] CaseFacadeEjbTest.testCaseExportWithPrescriptionsTreatmentsVisits:999 » IllegalState Required configuration 'COUNTRY_EPID_PREFIX' not found or invalid. Check if [ERROR] CaseFacadeEjbTest.testCaseExportWithSamples:1025 » IllegalState Required configuration 'COUNTRY_EPID_PREFIX' not found or invalid. Check if [ERROR] CaseFacadeEjbTest.testGetExportListNoDuplicates:1318 » IllegalState Required configuration 'COUNTRY_EPID_PREFIX' not found or invalid. Check if [ERROR] CaseFacadeEjbTest.testGetExportListWithRelevantVaccinations:1163 » IllegalState Required configuration 'COUNTRY_EPID_PREFIX' not found or invalid. Check if [ERROR] CaseFacadeEjbTest.testGetExportListWithoutDeletedSamples:1446 » IllegalState Required configuration 'COUNTRY_EPID_PREFIX' not found or invalid. Check if [ERROR] CaseFacadeEjbTest.testGetExportListWithoutRelevantVaccinations:1258 » IllegalState Required configuration 'COUNTRY_EPID_PREFIX' not found or invalid. Check if [ERROR] CaseFacadeEjbTest.testGetIndexListByEventFreeText:814 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] CaseFacadeEjbTest.testMergeCase:1869 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ConfigFacadeEjbTest.testValidateAppUrls:133 » NullPointer [ERROR] ConfigFacadeEjbTest.testValidateExternalUrls:46 » IllegalArgument Invalid URLs for which HTTPS is enforced in property file: ;, ;/auth/realms/;/protocol/openid-connect/certs, ;/auth/realms/;/protocol/openid-connect/token, ;/auth/realms/; [ERROR] HistoryTablesTest.testHistoryTablesMatch:53->start:85 » ContainerLaunch Container startup failed for image localhost/testcontainers/nbzcmglkb8tbq1fn:latest [ERROR] ContactFacadeEjbTest.testContactFollowUpStatusWhenConvertedCaseIsDeleted:484 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ContactFacadeEjbTest.testGetExportListWithRelevantVaccinations:1458 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ContactFacadeEjbTest.testGetExportListWithoutRelevantVaccinations:1576 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ContactFacadeEjbTest.testGetIndexDetailedList:987 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ContactFacadeEjbTest.testGetIndexListByEventFreeText:912 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] DashboardFacadeEjbTest.testDashboardEventListCreation:151 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] DashboardServiceTest.testGetEventCountByStatusWithArchivingAndDeletion:35 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SampleDashboardFacadeEjbTest.testGetSampleCountsWithNoDiseaseFlag:199 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] CoreEntityDeletionServiceTest.testCaseAutomaticDeletion:128 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] CoreEntityDeletionServiceTest.testEventAutomaticDeletion:340 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] CoreEntityDeletionServiceTest.testEventParticipantWithCaseSampleAutomaticDeletion:421 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] CoreEntityDeletionServiceTest.testEventParticipantWithEventSampleAutomaticDeletion:381 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] CoreEntityDeletionServiceTest.testSormasToSormasShareRequestPermanentDeletion:903 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventDocumentFacadeEjbTest.setup:53 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] QuarantineOrderFacadeEjbTest.setup:141 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] QuarantineOrderFacadeEjbTest.setup:141 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] QuarantineOrderFacadeEjbTest.setup:141 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] QuarantineOrderFacadeEjbTest.setup:141 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] QuarantineOrderFacadeEjbTest.setup:141 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] QuarantineOrderFacadeEjbTest.setup:141 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] QuarantineOrderFacadeEjbTest.setup:141 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] QuarantineOrderFacadeEjbTest.setup:141 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] QuarantineOrderFacadeEjbTest.setup:141 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] DocumentFacadeEjbTest.testDocumentCreation:55 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] DocumentFacadeEjbTest.testDocumentDeletion:95 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] DocumentFacadeEjbTest.testDocumentMimeTypeUnknown:119 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] DocumentFacadeEjbTest.testDuplicate:82 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] DocumentFacadeEjbTest.testExistingDocument:68 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbPseudonymizationTest.testEventInJurisdiction:85->createEvent:215 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbPseudonymizationTest.testEventOutsideJurisdiction:92->createEvent:215 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbPseudonymizationTest.testPseudonymizeGetByUuids:204->createEvent:215 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbPseudonymizationTest.testPseudonymizedGetByUuidWithLimitedUser:104 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbPseudonymizationTest.testUpdatePseudonymizedEvent:175->createEvent:215 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbPseudonymizationTest.testUpdateWithPseudonymizedDto:191->createEvent:215 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbTest.testArchiveAllArchivableEvents:445 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbTest.testArchiveOrDearchiveEvent:390 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbTest.testCreateWithoutUuid:509 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbTest.testEventCriteriaChangedSinceLastShareWithReportingTool:549 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbTest.testEventCriteriaLastShareWithReportingToolBetweenDates:576 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbTest.testEventCriteriaSharedWithReportingTool:520 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbTest.testEventDeletion:174 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbTest.testEventUpdate:222 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbTest.testGetEventByUuidForArchivedEvent:138 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbTest.testGetEventUsersWithoutUsesLimitedToOthersDiseses:663 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbTest.testGetEventsByPersonNationalHealthId:687 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbTest.testGetExportList:362 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbTest.testGetIndexList:253 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbTest.testGetIndexListByARestrictedAccessToAssignedEntities:305 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbTest.testGetSubordinateEventUuids:632 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventFacadeEjbUserFilterTest.testIndexListWhenParticipantIsInJurisdictionButEventIsNot:89 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventGroupFacadeEjbTest.testDeleteEventGroup:65 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventGroupFacadeEjbTest.testEditEventGroupWithEventsOutsideJurisdiction:149 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventGroupFacadeEjbTest.testGetEventGroupByUuidForArchivedGroup:111 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventGroupFacadeEjbTest.testGetIndexListWithNationalUserLimitedToCovid:185 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbPseudonymizationTest.testEventParticipantCasePersonWithSpecialAccess:249->createEventParticipant:275->createEventParticipant:279 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbPseudonymizationTest.testEventParticipantInJurisdiction:86->createEventParticipant:275->createEventParticipant:279 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbPseudonymizationTest.testEventParticipantOutsideJurisdiction:93->createEventParticipant:275->createEventParticipant:279 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbPseudonymizationTest.testPseudonymizeGetByUuids:172->createEventParticipant:275->createEventParticipant:279 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbPseudonymizationTest.testPseudonymizedGetByUuidWithLimitedUser:103->createEventParticipant:279 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbPseudonymizationTest.testUpdateOutsideJurisdiction:184->createEventParticipant:275->createEventParticipant:279 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbPseudonymizationTest.testUpdateWithPseudonymizedDto:219->createEventParticipant:275->createEventParticipant:279 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbTest.searchEventParticipantsByPersonEmail:614 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbTest.searchEventParticipantsByPersonOtherDetail:652 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbTest.searchEventParticipantsByPersonPhone:576 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbTest.testCreateWithoutUuid:349 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbTest.testEventParticipantIndexListSorting:545 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbTest.testEventParticipantTestResultWithMultipleSamples:431 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbTest.testEventParticipantWithArchivedEvent:487 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbTest.testExistEventParticipantWithDeletedFalse:404 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbTest.testExistEventParticipantWithDeletedTrue:417 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbTest.testGetByEventUuids:364 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbTest.testGetByPersonUuids:385 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbTest.testGetEventParticipantByUuidForArchivedParticipant:140 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbTest.testGetExportListWithRelevantVaccinations:176->createEvent:713 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbTest.testGetExportListWithoutRelevantVaccinations:290->createEvent:713 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbTest.testGetMatchingEventParticipants:277->createEvent:713 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbTest.testSaveEventParticipantWithEventArchiving:679->createEvent:713 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventParticipantFacadeEjbTest.testValidateWithNullReportingUser:95->createEvent:713 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventServiceTest.testGetEventSummaryDetailsByCasesEventArchivingAndDeletion:133 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventServiceTest.testGetEventSummaryDetailsByContactsEventArchivingAndDeletion:98 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventServiceTest.testHasAnyEventParticipantWithoutJurisdiction:77 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] EventServiceTest.testHasRegionAndDistrict:64 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ExternalEmailFacadeEjbTest.testEncryptAttachmentsWithRandomPassword:500 » Runtime java.io.FileNotFoundException: \opt\sormas\temp\sormas_temp_converted_2026-01-23_24621137.pdf (The system cannot find the path specified) [ERROR] ExternalEmailFacadeEjbTest.testSendEmailWithAttachments:421 » Runtime java.io.FileNotFoundException: \opt\sormas\temp\sormas_temp_converted_2026-01-23_452748649.pdf (The system cannot find the path specified) [ERROR] ExternalMessageFacadeEjbTest.testCountAndIndexListDoesNotReturnMessagesLinkedToDeletedEntities:241 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ExternalMessageFacadeEjbTest.testExistsLabMessageForEntityEventParticipant:200 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ExternalMessageServiceTest.testCountForEventParticipant:157 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] AbstractLabMessageProcessingFlowTest.testCreateEvent:1039->runFlow:3134 » Execution java.lang.IllegalStateException: Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] AbstractLabMessageProcessingFlowTest.testCreateEventAndCreateEventParticipant:1160->runFlow:3134 » Execution java.lang.IllegalStateException: Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] AbstractLabMessageProcessingFlowTest.testCreateEventAndCreateEventParticipantAndCreateSample:1251->runFlow:3134 » Execution java.lang.IllegalStateException: Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] AbstractLabMessageProcessingFlowTest.testCreateEventAndCreateEventParticipantAndCreateTwoSamples:1337->runFlow:3134 » Execution java.lang.IllegalStateException: Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] AbstractLabMessageProcessingFlowTest.testCreateEventCancel:1089->runFlow:3134 » Execution java.lang.IllegalStateException: Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] AbstractLabMessageProcessingFlowTest.testCreateEventParticipantCancel:1195->runFlow:3134 » Execution java.lang.IllegalStateException: Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] AbstractLabMessageProcessingFlowTest.testPickExistingEventAndCreateEventParticipant:1382 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] AbstractLabMessageProcessingFlowTest.testPickExistingEventAndPickExistingEventParticipantAndPickExistingSample:1617 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] AbstractLabMessageProcessingFlowTest.testPickExistingEventAndPickExistingEventParticipantPickExistingSampleAndCreateSample:1719 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] AbstractLabMessageProcessingFlowTest.testPickExistingEventParticipantAndCreateSample:2430 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] AbstractLabMessageProcessingFlowTest.testPickExistingEventParticipantAndPickExistingSample:2489 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] AbstractLabMessageProcessingFlowTest.testPickExistingEventWithExistingEventParticipantAndCancelThenCreateEvent:1556 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] AbstractLabMessageProcessingFlowTest.testPickExistingEventWithExistingEventParticipantAndCancelThenPickAgain:1501 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] AbstractLabMessageProcessingFlowTest.testPickExistingEventWithExistingEventParticipantAndCreateSample:1446 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ExternalSurveillanceToolGatewayFacadeEjbTest.testCaseAutomaticDeletion_WithoutCaseAllowedToBeSharedWithReportingTool:596 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ExternalSurveillanceToolGatewayFacadeEjbTest.testDeleteEvents:203->createEventDto:797 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ExternalSurveillanceToolGatewayFacadeEjbTest.testDeleteEventsNotFound:225->createEventDto:797 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ExternalSurveillanceToolGatewayFacadeEjbTest.testIsSharedEvent:417 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ExternalSurveillanceToolGatewayFacadeEjbTest.testSendingEventsOk:182->createEventDto:797 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ExternalSurveillanceToolGatewayFacadeEjbTest.testUpdateArchiveFlagInExternalSurveillanceToolForEvent_Exception:348 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ExternalSurveillanceToolGatewayFacadeEjbTest.testUpdateArchiveFlagInExternalSurveillanceToolForEvent_WithProperEntity:316 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] InfoFacadeEjbTest.testFieldsAddedBasedOnServerCountryForDataProtectionDictionary:90 » IO java.nio.file.NoSuchFileException: \opt\sormas\temp\sormas_temp_datadictionary_2026-01-23_774654617.xlsx [ERROR] ManualMessageLogFacadeEjbTest.testGetIndexListForEventParticipant:96 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] PersonFacadeEjbPseudonymizationTest.testGetEventParticipantPersonInSameJurisdiction:328 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] PersonFacadeEjbPseudonymizationTest.testGetEventParticipantPersonOutsideJurisdiction:338 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] PersonFacadeEjbPseudonymizationTest.testUpdateEventParticipantPersonInJurisdiction:348 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] PersonFacadeEjbPseudonymizationTest.testUpdateEventParticipantPersonOutsideJurisdiction:359 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] PersonFacadeEjbTest.testGetMatchingNameDtos:391 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] PersonFacadeEjbTest.testGetPersonByContext:1642 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] PersonFacadeEjbTest.testIsEditAllowedLinkedToEventParticipant:2022 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] PersonFacadeEjbTest.testIsEditAllowedLinkedToMultipleObjects:2180 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] PersonFacadeEjbTest.testIsEditAllowedLinkedToNotOwnedCaseAndDeletedAssociatedObject:2227 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] PersonFacadeEjbTest.testIsSharedOrReceived:2295 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] PersonFacadeEjbTest.testMergePersonWithMergeDuplicateEventParticipant:1400 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] PersonFacadeEjbTest.testMergePersonWithPickDuplicateEventParticipant:1474 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] PersonFacadeEjbTest.testMergePersonsAndRemoveDuplication:1026 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] PersonFacadeEjbTest.testMergePersonsSameMainAddress:1130 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] PersonFacadeEjbTest.testPersonAssociatedWithEventParticipant:1759 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] DeleteOldPathogenTestsAndSamplesTest.testNotConfigured:258 » IllegalState Required configuration 'NEGATIVE_COVID_TESTS_MAX_AGE_DAYS' not found or invalid. Check if [ERROR] SampleFacadeEjbTest.testCountAndGetSamplesForMap:1146 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SampleFacadeEjbTest.testGetIndexListBySampleAssociationType:214 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SampleFacadeEjbTest.testGetSimilarSamples:643 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SampleFacadeEjbTest.testIsEditAllowedSampleWithActiveEntity:1010 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SampleFacadeEjbTest.testIsEditAllowedSampleWithInactiveEntity:1033 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SampleFacadeEjbTest.testIsEditAllowedSampleWithInactiveEntityAndFeaturePropTrue:1065 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SampleFacadeEjbTest.testSamplesForActiveAndArchiveEventParticipant:928 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SampleFacadeEjbTest.testSaveSampleWithUnexistingEventParticipant:787 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ExternalShareInfoFacadeEjbTest.testGetIndexList:53 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ReceivedEntitiesProcessorTest.testIgnoredPropertiesAreNotOverwrittenWithNewValuesForEvent:176 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ReceivedEntitiesProcessorTest.testIgnoredPropertiesAreOverwrittenWithNewValuesForEvent:203 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SormasToSormasEventFacadeEjbTest.testReportingUserIsIncludedButUpdated:896 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SormasToSormasEventFacadeEjbTest.testReturnEvent:476 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SormasToSormasEventFacadeEjbTest.testSaveReturnedEvent:523 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SormasToSormasEventFacadeEjbTest.testSaveSharedEvents:350 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SormasToSormasEventFacadeEjbTest.testSaveSharedEventsWithParticipants:388 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SormasToSormasEventFacadeEjbTest.testSaveSharedEventsWithSamples:443 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SormasToSormasEventFacadeEjbTest.testSaveSyncedEvent:689 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SormasToSormasEventFacadeEjbTest.testShareEvent:98 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SormasToSormasEventFacadeEjbTest.testShareEventWithPseudonymizeData:176 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SormasToSormasEventFacadeEjbTest.testShareEventWithSamples:251 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SormasToSormasEventFacadeEjbTest.testSyncEvent:594 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SormasToSormasEventFacadeEjbTest.testSyncNotUpdateOwnedPerson:741 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] SormasToSormasEventFacadeEjbTest.testSyncRecursively:789 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ShareDataBuilderHelperTest.testClearIgnoredPropertiesForEvent:163 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] ShareDataBuilderHelperTest.testDoNotClearIgnoredPropertiesForEvent:190 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] TaskFacadeEjbTest.testArchivedTaskNotGettingTransfered:351 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] TaskFacadeEjbTest.testGetAllActiveTasksBatched:449 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] TaskFacadeEjbTest.testGetEditPermissionTypeOnEventTask:1071 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] TaskFacadeEjbTest.testGetIndexListArchived:951 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] TaskFacadeEjbTest.testGetIndexListByARestrictedAccessToAssignedEntitiesUser:274 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] TaskFacadeEjbTest.testGetTaskListForUserWithoutEventViewRight:762 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] TaskFacadeEjbTest.testUserWithoutEventViewRightSeeHisAssignTask:833 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] TaskFacadeEjbTest.testUserWithoutEventViewRightSeeHisObservedTask:891 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [ERROR] VaccinationFacadeEjbTest.testUpdateVaccinationStatuses:284 » IllegalState Required configuration 'COUNTRY_NAME' not found or invalid. Check if [INFO] [ERROR] Tests run: 1235, Failures: 22, Errors: 176, Skipped: 3

…g test approach

…nsertions:

sormas-vitagroup · 2026-01-28T08:40:03Z

SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13805

sormas-vitagroup · 2026-01-28T09:01:33Z

SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13805

sormas-vitagroup · 2026-01-28T10:53:38Z

SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13805

To make this work: - Enable AuditLogger and make it use legacy sormas.properties file - Make descriptions work for newly added - EmptyString instead of null because vaading textboxes doesn't like i.

Pa-Touche added 13 commits January 20, 2026 10:31

Added properties, started cleanup.

4aed4ae

Started refactoring to use new facade.

b56ac3c

continued refactoring.

8706ca9

(NOT TEST) code compiles again

67068d6

Reverted naming of files to reduce number of touched files.

a3fa251

renamed to old naming to limit changes.

77f0520

reverted unmodified files

26fc73e

revert for files which can be kept as it is

09abf9e

Starting trying to fix the unit tests.

cdd1fad

Approach to set the configuration values must change.

Started hacking unit tests, still a few missing things.

858b51e

Tests seem to compile but do not run yet.

ui-tests seem to pass somewhat.

5a638ed

UI tests fixed with new config approach.

1a97d3c

WARNING: requires setting some config within tests, as DB is not started and therefore not the new default configurations;

Pa-Touche added 16 commits January 23, 2026 14:16

Before fixing backend unit tests.

986a30a

stopped review a bit.

9dc1f52

missing schema file

c4f9f5a

limiting number of changes

11d4549

21 tests failing, almost there.

04b54ff

reducing number of touched files

b8449b5

merged with development

316591e

fixed case classification unit test

8647eca

tests are okay now except SystemConfiguration ones, before refactorin…

27cab25

…g test approach

before reverting SystemConfigurationValueEjb

0f08a58

defaulted to initial impl

8ae7acc

archunit failure

a5db304

started reverting

75b3d81

before understanding with treatment is broken

30a5245

Pa-Touche added 7 commits January 27, 2026 19:41

merge develop

24352ae

error during merge

48c839c

builds again

94a790b

all backend tests are green

7d4e94a

all backend tests are green

b89f929

working with Mock system config facade, before adding system config i…

6adf9d1

…nsertions:

unified approach

56e093e

Pa-Touche added 3 commits January 28, 2026 11:30

tests are green but i'm sometimes having flacky ones

99b3fa6

merged

aebd689

format

9a929d0

Pa-Touche added 6 commits January 28, 2026 13:07

reverting changes

a72a515

removed usage of externalclient

6ede05c

startup fails

cd3455d

only deadlock for now

88fa927

Almost starts?

281c8b3

without UI

ef6e116

Pa-Touche force-pushed the task/13278-replace_sormas-properties branch from b2cb18c to ef6e116 Compare January 29, 2026 19:13

Pa-Touche added 4 commits January 29, 2026 21:24

ear now ok.

db84cc4

issue when starting sormas-rest

47c2402

before commenting audit logging.

40ff465

DISABLED AuditLoggerEjb.

c99ff9d

To make this work: - Enable AuditLogger and make it use legacy sormas.properties file - Make descriptions work for newly added - EmptyString instead of null because vaading textboxes doesn't like i.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace properties based system configuration values#13805

Replace properties based system configuration values#13805
Pa-Touche wants to merge 49 commits intodevelopmentfrom
task/13278-replace_sormas-properties

Pa-Touche commented Jan 23, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 23, 2026 •

edited

Loading

Review skipped

Uh oh!

sormas-vitagroup commented Jan 28, 2026

Uh oh!

sormas-vitagroup commented Jan 28, 2026

Uh oh!

sormas-vitagroup commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Pa-Touche commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

sormas-vitagroup commented Jan 28, 2026

Uh oh!

sormas-vitagroup commented Jan 28, 2026

Uh oh!

sormas-vitagroup commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Pa-Touche commented Jan 23, 2026 •

edited

Loading

coderabbitai bot commented Jan 23, 2026 •

edited

Loading