Added some bindings for std::string_view when using c++17#224
Open
kaptenhonek wants to merge 7 commits intoSRombauts:masterfrom
Open
Added some bindings for std::string_view when using c++17#224kaptenhonek wants to merge 7 commits intoSRombauts:masterfrom
kaptenhonek wants to merge 7 commits intoSRombauts:masterfrom
Conversation
Author
|
Hm, it seems I found some issues, don't pull this yet |
Author
|
Ok, it should be working now |
Owner
|
Hello, would you perhaps be able to rebase / update this and fix the test coverage so I could merge it? |
Author
|
Sure, I'll fix it soon |
# Conflicts: # include/SQLiteCpp/Statement.h # src/Statement.cpp
Author
|
Ok this should be ready now. Due to me adding bind with const char* and length functions to bind text I had to change all binary blobs to unsigned char* so they will use the void* version. |
Owner
Author
|
Yeah, that seems like a wise idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title says it all :p