Added cmake variables to make submoduling the project easier#281
Open
abelmul wants to merge 1 commit intoSRombauts:masterfrom
abelmul:master
Open
Added cmake variables to make submoduling the project easier#281abelmul wants to merge 1 commit intoSRombauts:masterfrom abelmul:master
abelmul wants to merge 1 commit intoSRombauts:masterfrom
abelmul:master
Conversation
Owner
|
Hello, thanks for this proposal. I think that what you should do here is use the provided Find SQLiteCpp cmake file instead, no? Cheers |
Author
|
To quote the readme file in order to submodule and add this library you have to do add_subdirectory(${CMAKE_CURRENT_LIST_DIR}/thirdparty/SQLiteCpp)
include_directories(
${CMAKE_CURRENT_LIST_DIR}/thirdparty/SQLiteCpp/include
)
add_executable(main src/main.cpp)
target_link_libraries(main
SQLiteCpp
sqlite3
pthread
dl
)With this pull request you can do add_subdirectory(${CMAKE_CURRENT_LIST_DIR}/thirdparty/SQLiteCpp)
include_directories(${SQLITECPP_INCLUDE_DIRS})
add_executable(main src/main.cpp)
target_link_libraries(main ${SQLITECPP_LIBRARIES)I think it keeps application code clean. |
|
If linking multiple libraries is required then that hints at the fact that the SQLiteCpp target is missing some |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That explains it