Row: New class with iterators (WIP)#363
Open
Kacperos155 wants to merge 12 commits intoSRombauts:masterfrom
Open
Row: New class with iterators (WIP)#363Kacperos155 wants to merge 12 commits intoSRombauts:masterfrom
Kacperos155 wants to merge 12 commits intoSRombauts:masterfrom
Conversation
Contributor
Author
|
@SRombauts What do you think about this changes? |
Contributor
|
Ironically, I'd just done a simple iterator this morning before I saw yours. Mine was no where near as ambitious as yours, just basically a 80 line (mostly boiler-plate) wrapper around Statement. |
Move more statement info to StatementPtr. Replace int&uint16_t with int_fast16_t.
Contributor
Author
|
Iterator functionality is now working 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I'm trying to implement:
Should be RandomAccessIterator but this is too much boilerplate code for probably non-existing gain.
Examples: