Add 6 Statement::bind() overrides using size_t for blobs#431
Open
Add 6 Statement::bind() overrides using size_t for blobs#431
Conversation
Fix #430 for a better support of standard containers Also add a couple of tests (not covering all variants)
Owner
Author
|
It's not a "real-life issue" since SQLiteCpp can only bind a blob with a size in int. |
|
I am currently using this great library. Thank you for this! One issue I'm running into is binding a blob breaks the variadic binding possiblity, because it requires two parameters, not one. So I would like to introduce a new struct // [...]
struct Blob {
const void *ptr;
std::size_t size;
};
SQLite::bind(st, "ABC", 2, SQLite::Blob{"def", 3});I think this would perfectly fit in this PR, what do you think? |
|
@SRombauts do you think this will ever get merged (in addition to my comment?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #430 for a better support of standard containers
Also add a couple of tests (not covering all variants)