fix: update the c++ version selection process#511
fix: update the c++ version selection process#511SGSSGene wants to merge 2 commits intoSRombauts:masterfrom
Conversation
|
Hey @SGSSGene, that sounds like a nice improvement as well, thanks for taking the time to provide the PR! |
| add_library(SQLiteCpp ${SQLITECPP_SRC} ${SQLITECPP_INC} ${SQLITECPP_DOC} ${SQLITECPP_SCRIPT}) | ||
|
|
||
| # set minimum version to c++11 | ||
| target_compile_features(SQLiteCpp PUBLIC cxx_std_11) |
There was a problem hiding this comment.
The cxx_std_11 compiler meta-feature is not available CMake 3.5 (which was the minimal version until now, see line 7 cmake_minimum_required(VERSION 3.5))
It was introduced in 3.8, CMake 3.8 release notes
Could you please also update the minimum version?
Thanks!
|
@SRombauts: All changes that we currently do downstream in the OpenMS project :-) What CMake version is suitable? |
Then, if you have any other pull request with more changes requiring another bump, I would evaluate that again. |
The c++ version should be set via `target_compile_features(SQLiteCpp PUBLIC cxx_std_11)` This only sets this as a minimum version for this target, and not all targets.
SGSSGene
force-pushed
the
fix/modern_cpp_version_selection
branch
from
2839628 to
21c371a
Compare
2 participants
The c++ version should be set via
target_compile_features(SQLiteCpp PUBLIC cxx_std_11)This only sets this as a minimum version for this target, and not all targets.