Should not detect a breaking change when corresponding basePath & operationChange lead to same Endpoints.#28
Open
LasseGosch wants to merge 247 commits intoSayi:masterfrom
Open
Should not detect a breaking change when corresponding basePath & operationChange lead to same Endpoints.#28LasseGosch wants to merge 247 commits intoSayi:masterfrom
LasseGosch wants to merge 247 commits intoSayi:masterfrom
Conversation
…ave changed. A changed basePath with a corresponding change of the operationPaths could lead to unchanged endpoints and should not be detected as a breaking change. Added a test (in SwaggerDiffTest) and resources (.yamls) for that case.
Bumps [junit](https://github.com/junit-team/junit4) from 4.8.2 to 4.13. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/master/doc/ReleaseNotes4.13.md) - [Commits](junit-team/junit4@r4.8.2...r4.13) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Integrate parent POM
Bumps swagger-compat-spec-parser from 1.0.31 to 1.0.50. Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [swagger-parser](https://github.com/swagger-api/swagger-parser) from 1.0.31 to 1.0.50. - [Release notes](https://github.com/swagger-api/swagger-parser/releases) - [Commits](swagger-api/swagger-parser@v1.0.31...v1.0.50) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…agger-compat-spec-parser-1.0.50
…wagger-parser-1.0.50
Bumps swagger-models from 1.5.15 to 1.6.0. Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…wagger-models-1.6.0 Bump swagger-models from 1.5.15 to 1.6.0
Before a parameter that has been changed was not removed from the list of new parameters.
Bumps swagger-models from 1.6.0 to 1.6.2. Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [junit](https://github.com/junit-team/junit4) from 4.13 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.1.md) - [Commits](junit-team/junit4@r4.13...r4.13.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps commons-lang3 from 3.2.1 to 3.12.0. Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [jcommander](https://github.com/cbeust/jcommander) from 1.72 to 1.81. - [Release notes](https://github.com/cbeust/jcommander/releases) - [Changelog](https://github.com/cbeust/jcommander/blob/master/CHANGELOG.md) - [Commits](https://github.com/cbeust/jcommander/commits/1.81) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [swagger-parser](https://github.com/swagger-api/swagger-parser) from 1.0.50 to 1.0.55. - [Release notes](https://github.com/swagger-api/swagger-parser/releases) - [Commits](swagger-api/swagger-parser@v1.0.50...v1.0.55) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps swagger-compat-spec-parser from 1.0.50 to 1.0.55. Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [j2html](https://github.com/tipsy/j2html) from 1.2.0 to 1.5.0. - [Release notes](https://github.com/tipsy/j2html/releases) - [Changelog](https://github.com/tipsy/j2html/blob/master/docs/news.html) - [Commits](tipsy/j2html@j2html-1.2.0...j2html-1.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 1.6.3 to 1.7.32. - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…yi-master # Conflicts: # pom.xml # src/main/java/com/deepoove/swagger/diff/compare/ListDiff.java
Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 2.0.5 to 2.0.6. - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](qos-ch/slf4j@v_2.0.5...v_2.0.6) --- updated-dependencies: - dependency-name: org.slf4j:slf4j-api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…lf4j-api-2.0.6 Bump slf4j-api from 2.0.5 to 2.0.6
Bumps parent from 0.9.13 to 0.9.14. --- updated-dependencies: - dependency-name: de.lars-sh:parent dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…parent-0.9.14 Bump parent from 0.9.13 to 0.9.14
Bumps [com.google.guava:guava](https://github.com/google/guava) from 31.1-jre to 32.0.0-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-version: 32.0.0-jre dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps org.apache.commons:commons-lang3 from 3.12.0 to 3.18.0. --- updated-dependencies: - dependency-name: org.apache.commons:commons-lang3 dependency-version: 3.18.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…guava-guava-32.0.0-jre Bump com.google.guava:guava from 31.1-jre to 32.0.0-jre
…commons-commons-lang3-3.18.0 Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.18.0
Bumps org.slf4j:slf4j-api from 2.0.6 to 2.0.17. --- updated-dependencies: - dependency-name: org.slf4j:slf4j-api dependency-version: 2.0.17 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [com.fasterxml.jackson.core:jackson-databind](https://github.com/FasterXML/jackson) from 2.14.1 to 2.20.0. - [Commits](https://github.com/FasterXML/jackson/commits) --- updated-dependencies: - dependency-name: com.fasterxml.jackson.core:jackson-databind dependency-version: 2.20.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [com.alibaba:fastjson](https://github.com/alibaba/fastjson2) from 2.0.21 to 2.0.59. - [Release notes](https://github.com/alibaba/fastjson2/releases) - [Commits](alibaba/fastjson2@2.0.21...2.0.59) --- updated-dependencies: - dependency-name: com.alibaba:fastjson dependency-version: 2.0.59 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Ignore JUnit 6 because it's missing JDK8 support
…lf4j-api-2.0.17 Bump org.slf4j:slf4j-api from 2.0.6 to 2.0.17
…ml.jackson.core-jackson-databind-2.20.0 Bump com.fasterxml.jackson.core:jackson-databind from 2.14.1 to 2.20.0
…-fastjson-2.0.59 Bump com.alibaba:fastjson from 2.0.21 to 2.0.59
Bumps org.apache.commons:commons-lang3 from 3.18.0 to 3.19.0. --- updated-dependencies: - dependency-name: org.apache.commons:commons-lang3 dependency-version: 3.19.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps io.swagger:swagger-models from 1.6.9 to 1.6.16. --- updated-dependencies: - dependency-name: io.swagger:swagger-models dependency-version: 1.6.16 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [com.google.guava:guava](https://github.com/google/guava) from 32.0.0-jre to 33.5.0-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-version: 33.5.0-jre dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [io.swagger:swagger-parser](https://github.com/swagger-api/swagger-parser) from 1.0.64 to 1.0.75. - [Release notes](https://github.com/swagger-api/swagger-parser/releases) - [Commits](swagger-api/swagger-parser@v1.0.64...v1.0.75) --- updated-dependencies: - dependency-name: io.swagger:swagger-parser dependency-version: 1.0.75 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps io.swagger:swagger-compat-spec-parser from 1.0.64 to 1.0.75. --- updated-dependencies: - dependency-name: io.swagger:swagger-compat-spec-parser dependency-version: 1.0.75 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…guava-guava-33.5.0-jre Bump com.google.guava:guava from 32.0.0-jre to 33.5.0-jre
…swagger-models-1.6.16 Bump io.swagger:swagger-models from 1.6.9 to 1.6.16
…swagger-parser-1.0.75 Bump io.swagger:swagger-parser from 1.0.64 to 1.0.75
…commons-commons-lang3-3.19.0 Bump org.apache.commons:commons-lang3 from 3.18.0 to 3.19.0
…swagger-compat-spec-parser-1.0.75 Bump io.swagger:swagger-compat-spec-parser from 1.0.64 to 1.0.75
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added taking basePath into consideration when checking if endpoints have changed.
A changed basePath with a corresponding change of the operation paths could lead to unchanged endpoints and should not be detected as a breaking change.
Added a test (in SwaggerDiffTest) and resources (.yamls) for that case.
Removed unused SWAGGER_V2_HTTP from SwaggerDiffTest.