Asaad fix reference recognizer #64
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context and description of issue
In this issue (part 2) I identified an issue with the
BasicReferenceRecognizer. Namely, when no reference to an aspect is detected, the auxiliary model overrides the prediction from ABSA withneutralsentiment and withscores = [0, 0, 0]. Notable, the entries inscoresare of typeint.The problem is that, further down the pipeline in the preprocessing step,
scoresis required to be an array of typefloatin order to be normalised. If we pass[0, 0, 0]to the postprocessing step, the following error will be raised:Main contribution
This PR does two things to ensure that
scorescan be successfully normalised:scores = [0.0, 0.0, 0.0]in theProfessor'sreviewmethod to ensure it is of typeList[float];scoresto have entries of typefloatin thePipelinestatic methodpostprocess.