Fix SpeedMapping 0.4 compatibility #747
Merged
+26
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpeedMapping 0.4 introduced breaking API changes:
- `converged::Bool` -> `status::Symbol` in return type
- `tol` -> `abstol`
- `Lp` -> `pnorm`
- `store_info` -> `store_trace`
- `σ_min` -> `initial_learning_rate`
- `orders::Vector{Int}` -> `orders::Tuple`
This commit updates the extension to use the 0.4 API exclusively
and changes the compat entry from "0.3, 0.4" to "0.4".
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ChrisRackauckas-Claude
force-pushed
the
fix-speedmapping-0.4-compat
branch
from
4d5f3af to
cca0b4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the compatibility issue with SpeedMapping 0.4 by updating the extension to use the new API and dropping support for 0.3.
SpeedMapping 0.4 introduced breaking API changes:
converged::Boolstatus::Symbol(:first_order,:max_eval, etc.)tolabstolLppnormstore_infostore_traceσ_mininitial_learning_rateVector{Int}TupleChanges
ext/NonlinearSolveSpeedMappingExt.jlto use SpeedMapping 0.4 API"0.3, 0.4"to"0.4"(dropping 0.3 support)Test plan
This PR supersedes #745 (the CompatHelper bump) - once merged, #745 can be closed.
🤖 Generated with Claude Code