Skip to content

Conversation

@trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Aug 20, 2024

🚀 Pull Request

Description

Closes #6122

To do


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@trexfeathers trexfeathers added Feature: UGRID Type: Feature Branch Highlight this for a feature branch labels Aug 20, 2024
@trexfeathers trexfeathers added this to the v3.13 milestone Apr 3, 2025
@bjlittle bjlittle moved this to 🆕 Candidate in 🦋 Iris 3.13.0 Apr 23, 2025
@stephenworsley stephenworsley moved this to 🆕 Candidate in 🦌 Iris 3.14 Aug 28, 2025
@stephenworsley stephenworsley moved this from 🆕 Candidate to 📚 Backlog in 🦌 Iris 3.14 Sep 2, 2025
@ESadek-MO ESadek-MO moved this from 📚 Backlog to 🔖 Assigned in 🦌 Iris 3.14 Sep 18, 2025
@trexfeathers
Copy link
Contributor Author

Some notes after revisiting:

  • I went hard to avoid the parent class (MeshXY) needing to know about the subclass (_MeshIndexSet), since that would obviously be an anti-pattern. But in doing so I just added a load of other anti-patterns instead (e.g. self.__class__ = ...). The better way to achieve this would be a _MeshXYMixin1, providing common behaviour for both MeshXY and _MeshIndexSet, but easily allowing for completely different __init__ etcetera.
  • I need to find a way to have the docs render _MeshIndexSet, while still keeping it private:
    https://github.com/trexfeathers/iris/blob/41cbe93b2d6c4a69fc9a0b8ed759540f5f9c5a42/lib/iris/mesh/components.py#L2021-L2023

Footnotes

  1. _MeshMixin in future: https://github.com/SciTools/iris/blob/57a316c8a7ebfb4052081537f408204ab0781ba5/lib/iris/mesh/components.py#L598-L608

@stephenworsley stephenworsley moved this from 🔖 Assigned to 🚀 In Progress in 🦌 Iris 3.14 Sep 22, 2025
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Sep 24, 2025
@stephenworsley stephenworsley moved this from 🚀 In Progress to 🚧 Blocked in 🦌 Iris 3.14 Oct 8, 2025
@ESadek-MO ESadek-MO mentioned this pull request Oct 29, 2025
@trexfeathers trexfeathers modified the milestones: v3.13, v3.15 Dec 29, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Iris v3.15 Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: UGRID Type: Feature Branch Highlight this for a feature branch

Projects

Status: Backlog
Status: No status
Status: 🚧 Blocked
Status: 🆕 Candidate

Development

Successfully merging this pull request may close these issues.

2 participants