Skip to content

Refactored Porter to no longer be a repository of providers #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Bilge wants to merge 1 commit into from
Closed

Refactored Porter to no longer be a repository of providers #38

Bilge wants to merge 1 commit into from

Conversation

@Bilge
Copy link
Member

@Bilge Bilge commented Jun 19, 2017

  • Porter now composes a container of providers received in its constructor instead of acting as a provider registry directly.
  • Provider tags have been removed since they are redundant.
  • Provider class name specified by resources can be overridden by calling ImportSpecification::setProviderName.

@Bilge Bilge added this to the 4.0.0 milestone Jun 19, 2017
@Bilge
Refactored Porter to no longer be a repository of providers.
b63a1e3 
Added Porter constructor that receives a container of providers.
Removed provider tags.
@Bilge Bilge force-pushed the remove-provider-tags branch from 11f57f0 to b63a1e3 Compare June 19, 2017 23:32
@Bilge Bilge mentioned this pull request Oct 25, 2017
Merged
@Bilge
Copy link
Member Author

Bilge commented Apr 9, 2018

Included in #46.

@Bilge Bilge closed this Apr 9, 2018
@Bilge Bilge deleted the remove-provider-tags branch April 9, 2018 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

improvement

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Bilge