Rewrote CachingConnector as decorator #44
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed CacheAdvice (simplified to boolean). Removed obsolete Cache interface. Renamed SuperConnector -> ImportConnector and added class comment.
Removed dependency on eloquent/enumeration.
Bilge
force-pushed
the
caching-connector-decorator
branch
from
7800193 to
e754328
Compare
Codecov Report
@@ Coverage Diff @@
## connection-context #44 +/- ##
====================================================
+ Coverage 99.74% 100% +0.25%
====================================================
Files 29 29
Lines 391 372 -19
====================================================
- Hits 390 372 -18
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
Added test for ImportSpecification::disableCache() to complete code coverage.
Bilge
force-pushed
the
caching-connector-decorator
branch
from
8a63cb9 to
45bbb18
Compare
Member
Author
|
Included in #46. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This key change brings the following improvements to
CachingConnector.Connectorimplementations no longer have to extendCachingConnectorto provide caching facilities: all connectors can be decorated withCachingConnectorwith no prior knowledge of the existence of such facility. This completely removes the burden on implementations to be aware of caching concerns.Connectorimplementations to use however else they see fit.Technical changes
CachingConnectorfrom abstract class to concrete decorator.CachedAdvicewith simple boolean (cache or cache not; there is no try).Cacheinterface.SuperConnector->ImportConnector.