Added provider fetch exception handler to ImportConnector #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilge
changed the title
Codecov Report
@@ Coverage Diff @@
## 4.0 #49 +/- ##
===================================
Coverage 100% 100%
===================================
Files 29 29
Lines 327 335 +8
===================================
+ Hits 327 335 +8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since connectors now wrap their fetch code in an error trapping block (using
ConnectionContext::retry), resources no longer have the option of catching low level connector exceptions themselves (they are intercepted by the fetch exception handler). However, resources need a way to determine if a recoverable exception should be promoted to fatal, or receive other special handling, so they now have the option of specifying a provider fetch exception handler, which is executed before the user-defined fetch exception handler set in theImportSpecification.