Skip to content

Conversation

@Bilge
Copy link
Member

@Bilge Bilge commented Apr 3, 2018

  • Added StatelessFetchExceptionHandler and ExponentialSleepFetchExceptionHandler FEH implementations.
  • Changed FEH defacto type from callable to FetchExceptionHandler throughout Porter.

@Bilge Bilge added this to the 4.0.0 milestone Apr 3, 2018
@Bilge Bilge force-pushed the fetch-exception-handler branch from 6169279 to 3571ab8 Compare April 3, 2018 23:12
Added Stateless- and ExponentialSleep FetchExceptionHandler implementations.
Changed FEH defacto type from callable to FetchExceptionHandler.
@Bilge Bilge force-pushed the fetch-exception-handler branch from 3571ab8 to 3fd8a02 Compare April 3, 2018 23:24
@codecov-io
Copy link

codecov-io commented Apr 3, 2018

Codecov Report

Merging #50 into 4.0 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            4.0    #50   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        27     29    +2     
  Lines       323    339   +16     
===================================
+ Hits        323    339   +16
Impacted Files Coverage Δ
...nHandler/ExponentialSleepFetchExceptionHandler.php 100% <100%> (ø)
src/Connector/ImportConnector.php 100% <100%> (ø) ⬆️
...xceptionHandler/StatelessFetchExceptionHandler.php 100% <100%> (ø)
src/Connector/ConnectionContext.php 100% <100%> (ø) ⬆️
src/Specification/ImportSpecification.php 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bae9b7...76d3909. Read the comment docs.

@Bilge Bilge force-pushed the fetch-exception-handler branch 2 times, most recently from 1b8a69c to 7eab4e3 Compare April 4, 2018 23:32
Changed "provider" FEH name to "resource" fetch exception handler.
Changed resource FEH type from callable to FetchExceptionHandler.
@Bilge Bilge force-pushed the fetch-exception-handler branch from 7eab4e3 to 9c8af41 Compare April 4, 2018 23:41
…onContext.

Fixed type hints in ImportConnector from callable -> FetchExceptionHandler.
@Bilge Bilge merged commit 76d3909 into 4.0 Apr 5, 2018
@Bilge Bilge deleted the fetch-exception-handler branch April 9, 2018 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants