Added ConnectorWrapper interface #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing CachingConnector::__clone() method. Added ImportConnector::findBaseConnector(). Changed CachingConnector to implement ConnectorWrapper. Changed ImportConnector to clone its connector instead of relying on caller. Fixed some ImportSpecification docblocks.
Codecov Report
@@ Coverage Diff @@
## 4.0 #51 +/- ##
===================================
Coverage 100% 100%
===================================
Files 29 29
Lines 343 352 +9
===================================
+ Hits 343 352 +9
Continue to review full report at Codecov.
|
Bilge
force-pushed
the
connector-wrapper
branch
2 times, most recently
from
e382720 to
2eff2cb
Compare
Added test for CachingConnector::__clone().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This final PR for 4.0 RC adds the the missing
__clone()method and a method to access the wrapped connector inCachingConnector. It also adds a newfindBaseConnector()method toImportConnectorto save callers having to callgetWrappedConnector()multiple times.getWrappedConnector()is now specified by the newConnectorWrapperinterface.Technical changes
CachingConnector::__clone()method.ImportConnector::findBaseConnector().CachingConnectorto implementConnectorWrapper.ImportConnectorto clone its connector instead of relying on caller.ImportSpecificationdocblocks.