-
Notifications
You must be signed in to change notification settings - Fork 1
fix: add extensions to relative path import specifiers #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: b93cb1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughWalkthroughReplace various Prettier module specifiers to include explicit file extensions (e.g., Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
4766d54 to
fcb2ac9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request fixes issue #147 by adding explicit .js file extensions to relative path import specifiers throughout the codebase, ensuring proper ESM module resolution. The changes address TypeScript/Node.js ESM compatibility requirements where explicit extensions are needed for relative imports.
Changes:
- Updated all
prettier/docimports toprettier/doc.jsacross 27 source files - Updated test import from
../srcto../src/index.js - Added changeset documentation for the patch release
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.changeset/pink-nails-reply.md |
Adds changeset entry documenting the fix as a patch release |
tests/fixtures.spec.ts |
Updates test import to include explicit .js extension for ESM compatibility |
src/utils.ts |
Updates prettier/doc import to prettier/doc.js |
src/types.ts |
Updates prettier/doc type import to prettier/doc.js |
src/embedded/*/embedder.ts (26 files) |
Updates all embedder imports from prettier/doc to prettier/doc.js for consistent ESM resolution |
src/embedded/utils.ts |
Updates prettier/doc import to prettier/doc.js |
src/embedded/html/embedder.ts |
Updates prettier/doc import to prettier/doc.js |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Attemp to fix #147
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.