Fix/share request under your docs #202
Conversation
| @@ -1,11 +1,3 @@ | |||
| <% if @requests.any? %> | |||
There was a problem hiding this comment.
Check with @rosspatel01 , but I think he meant that this section should be after the heading, rather than after all of the documents
There was a problem hiding this comment.
Good point, I might have interpreted it differently 😛
|
|
|
I think that's a separate issue @Br3nda |
|
I got to here & unsure what the design should be to accommodate 3 buttons. |
…eInnovationLab/feijoa into fix/share-request-under-your-docs
|
The information hierarchy is also a bit off there - the notes are much larger than anything else |
…eInnovationLab/feijoa into fix/share-request-under-your-docs
|
Current look: |
| <div class="card-header"> | ||
| <h3>Request for <%= t("documents.types.#{request.document_type}") %></h3> | ||
| </div> | ||
| <div class="card card--with-fancy-footer birth-record card--"> |
There was a problem hiding this comment.
Where is this change coming from @JacOng17 - this isn't in Ross's designs or requested in the trello card
|
I've redone moving the share requests in another PR - can you explain what your plan was with the cards here? |
|
@mermop Ross mentioned that he wanted the card to look alike, so I started on that. Was stuck cos he didn't factor the cards with 3 buttons & was waiting till he gave me more info, so I didn't proceed from there. |
Moved Share requests section under Your Documents.
Trello: https://trello.com/c/7FNrgD2F/94-place-new-share-requests-underneath-the-your-documents-dashboard-title
@rosspatel01
Should it be:
OR:
