Switching _agents_on_benchmark to Study method for flexibility#228
Merged
gabrielhuang merged 2 commits intomainfrom Mar 3, 2025
Merged
Switching _agents_on_benchmark to Study method for flexibility#228gabrielhuang merged 2 commits intomainfrom
gabrielhuang merged 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
I've completed my review and didn't find any issues... but I did find this chicken.
\\
(o>
<_ )
^^Files scanned
| File Path | Reviewed |
|---|---|
| src/agentlab/experiments/study.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ✅ Issue Categories
Category Enabled Documentation ✅ Logging ✅ Error Handling ✅ Readability ✅ Design ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
Collaborator
|
Thank you, this will allow me to instantiate custom exparg subclasses |
gabrielhuang
approved these changes
Mar 3, 2025
Collaborator
gabrielhuang
left a comment
There was a problem hiding this comment.
exactly what i needed thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description by Korbit AI
What change is being made?
Move the
_agents_on_benchmarkfunction to theStudyclass as a method namedagents_on_benchmarkto enhance flexibility in executing experiments.Why are these changes being made?
This change improves the modularity and encapsulation by aligning the method with the responsibilities of the
Studyclass, enabling better manageability and potential future extensions. It also fixes import ordering, ensuring clarity and consistency in module dependencies.