Fix: cache breakpoint handling in StructuredDiscussion class. #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anthropic requires maximum 4 cache breakpoints per request. This unsets cache breakpoints from earlier messages and only adds a single breakpoint in the flatten() method.
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues... but I did find this frog.
.--._.--.
( O O )
/ . . \
.`._______.'.
/( )\
_/ \ \ / / \_
.~ ` \ \ / / ' ~.
{ -. \ V / .- }
_ _`. \ | | | / .'_ _
>_ _} | | | {_ _<
/. - ~ ,_-' .^. `-_, ~ - .\
'-'|/ \|`-`Files scanned
| File Path | Reviewed |
|---|---|
| src/agentlab/agents/tool_use_agent/tool_use_agent.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anthropic requires maximum 4 cache breakpoints per request. This unsets cache breakpoints from earlier messages and only adds a single breakpoint in the flatten() method.
Description by Korbit AI
What change is being made?
Fix the cache breakpoint handling in the
StructuredDiscussionclass by resetting previous cache breakpoints before setting a new one.Why are these changes being made?
The previous implementation did not properly handle the cache breakpoints, only marking the last message for caching. This change ensures that all previous cache breakpoints are reset, avoiding potential issues with incorrect caching in the
ToolUseAgent.