Skip to content

Xray fixes for backward (pre bgym v0.14.2) compatibility #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
recursix merged 2 commits into from
Aug 6, 2025
Merged

Xray fixes for backward (pre bgym v0.14.2) compatibility #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dd87c4
fix readme link for os world
amanjaiswal73892 Aug 6, 2025
fd19a3d
Fix: check profile keys check for backward (pre bgym v0.14.2) compati…
amanjaiswal73892 Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ AgentLab Features:
| [GAIA](https://huggingface.co/spaces/gaia-benchmark/leaderboard) (soon) | - | - | None | - | - | live web | soon |
| [Mind2Web-live](https://huggingface.co/datasets/iMeanAI/Mind2Web-Live) (soon) | - | - | None | - | - | live web | soon |
| [MiniWoB](https://miniwob.farama.org/index.html) | [setup](https://github.com/ServiceNow/BrowserGym/blob/main/browsergym/miniwob/README.md) | 125 | Medium | 10 | no | self hosted (static files) | soon |
| [OSWorld](https://os-world.github.io/) | [setup](https://github.com/ServiceNow/AgentLab/blob/main/src/agentlab/benchmarks/setup.md) | 369 | None | - | - | self hosted | soon |
| [OSWorld](https://os-world.github.io/) | [setup](https://github.com/ServiceNow/AgentLab/blob/main/src/agentlab/benchmarks/osworld.md) | 369 | None | - | - | self hosted | soon |


## 🛠️ Setup AgentLab
Expand Down
13 changes: 11 additions & 2 deletions src/agentlab/analyze/agent_xray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1312,6 +1312,7 @@ def plot_profiling(ax, step_info_list: list[StepInfo], summary_info: dict, progr
# NEW: Add wait for page loading visualization
if (
hasattr(prof, "wait_for_page_loading_start")
and prof.wait_for_page_loading_start is not None
and prof.wait_for_page_loading_start > 0
):
add_patch(
Expand All @@ -1323,7 +1324,11 @@ def plot_profiling(ax, step_info_list: list[StepInfo], summary_info: dict, progr
)

# NEW: Add validation visualization
if hasattr(prof, "validation_start") and prof.validation_start > 0:
if (
hasattr(prof, "validation_start")
and prof.validation_start is not None
and prof.validation_start > 0
):
add_patch(
ax,
prof.validation_start,
Expand All @@ -1333,7 +1338,11 @@ def plot_profiling(ax, step_info_list: list[StepInfo], summary_info: dict, progr
)

# NEW: Add get observation visualization
if hasattr(prof, "get_observation_start") and prof.get_observation_start > 0:
if (
hasattr(prof, "get_observation_start")
and prof.get_observation_start is not None
and prof.get_observation_start > 0
):
add_patch(
ax,
prof.get_observation_start,
Expand Down