Add Environment Variable for Ray port #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review by Korbit AIKorbit automatically attempts to detect when you fix issues in new commits.
Files scanned
|
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
Comment on lines
11
to
+12
| RAY_PUBLIC_DASHBOARD = os.environ.get("RAY_PUBLIC_DASHBOARD", "false") == "true" | ||
| RAY_DASHBOARD_PORT = os.environ.get("RAY_DASHBOARD_PORT") |
There was a problem hiding this comment.
Hard-coded Configuration 
Tell me more
What is the issue?
Configuration values are defined at module level and directly dependent on environment variables, making the code less flexible and harder to test.
Why this matters
Hard-coded configuration reduces reusability and makes testing more difficult as it requires environment manipulation.
Suggested change ∙ Feature Preview
Move configuration to a dedicated config class or function:
def get_ray_config(config_dict=None):
config = config_dict or {}
return {
'dashboard_public': config.get('RAY_PUBLIC_DASHBOARD', os.environ.get('RAY_PUBLIC_DASHBOARD', 'false') == 'true'),
'dashboard_port': config.get('RAY_DASHBOARD_PORT', os.environ.get('RAY_DASHBOARD_PORT'))
}Provide feedback to improve future suggestions
💬 Looking for more details? Reply to this comment to chat with Korbit.
amanjaiswal73892
requested changes
Nov 5, 2025
Collaborator
amanjaiswal73892
left a comment
amanjaiswal73892
left a comment
There was a problem hiding this comment.
LGTM! It will be useful to document these variables in the readme along with the other variables.
amanjaiswal73892
added a commit
that referenced
this pull request
Nov 27, 2025
* fixes * add new deps * use external embedding service in task hints retrieval * gpt5 fixes * first cut * update * add event listeners and launcher * Add codegen step-wise recoder agent * adding task hints to generic agent * fix repeated llm configs * load env vars in codegen agent * same hints retrieval for both generic and tooluse agents * filter out current task hints if needed * fix llm config, add gpt-5 * fix * pass new flag and fix db path passing issue * fix goal text * fix current task hints exclusion * remove old reqs * remove recorder from that brach * log task errors * expore agentlabxray * remove commented old chunk * share xray only when env flag present * Add StepWiseQueriesPrompt for enhanced query handling in GenericAgent * update hinting agent retrieval * stepwise hint retrieval * added shrink method * (wip) refactor hinting index * (wip) clean up prompt file * add scripts to run generic and hinter agents, update tmlr config for hinter * move HintsSource to separate hinting file * update hinter agent and prompt * fix prompt for task hint * undo changes to tmlr config * update hinter agent * formatting * bug fix hint retrieval * improve launch script * get queries only for step level hint * Add webarenalite to agentlab loop.py * update stepwise hint queries prompt * fix exc logging * non empty instruction * allow less then max hint queries * add generic agent gpt5-nano config * make ray available on toolkit * check that hints db exists * Fix assignment of queries_for_hints variable * Improve generic agent hinter (#309) * Make LLM retreival topic index selection more robust * add new flag to skip hints with the current goal in the hint source t… (#310) * add new flag to skip hints with the current goal in the hint source traces * Rename generic agent hinter to hint_use_agent (#311) * rename generic_agent_hinter to hint_use_agent for clarity * Add deprecation warning and module alias for generic_agent_hinter * improve module aliasing for submodules * Add todo rename agent name * black * bugfix: check for hint_db only when use_task_hint is true. * fix: address missing initialization and correct args reference in choose_hints method * black * bugfix: skip HintSource init if use_task_hint is false * Fix incorrect references for docs retrieval hinter agent (#313) * address comments * format * Add Environment Variable for Ray port (#315) * add env variable for ray port * document env variables * undo removed llm_config * undo unnessary change * add missing default values for hint prompt flags * black * update names in scripts * use default prompt in hintSource for Tool Use agent * remove experiment scripts --------- Co-authored-by: Oleh Shliazhko <oleh.shliazhko@servicenow.com> Co-authored-by: Hadi Nekoei <had.nekoeiqachkanloo@servicenow.com> Co-authored-by: Oleh Shliazhko <ollmer@users.noreply.github.com> Co-authored-by: recursix <alex.lacoste.shmu@gmail.com> Co-authored-by: Patrice Bechard <patrice.bechard@servicenow.com> Co-authored-by: Hadi Nekoei <hadinekoei94@gmail.com> Co-authored-by: Patrice Bechard <bechardpatrice@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.