[SPH][Phys] add Fermi gas EoS #1405
Draft
+179
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of ChangesHello @DavidFang03, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the simulation capabilities by adding a Fermi gas Equation of State. This new EoS is fully integrated into the system's configuration and computation modules, providing a robust framework for its use. The changes ensure that the new EoS can be selected, configured, and used in calculations, enhancing the model's physical accuracy for relevant scenarios. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully adds the Fermi gas equation of state. The implementation is spread across several files to integrate the new EoS into the existing framework, including configuration, JSON serialization, Python bindings, and the core computation kernel.
I've made a few suggestions to improve code clarity, documentation, and performance. Notably, there's an opportunity to optimize the EOS_Fermi calculation by computing pressure and sound speed together to avoid redundant calculations. I also found a misleading comment in eos_config.hpp that should be corrected.
Regarding your question about units, your usage of shamunits::Constants<T>::Si::... in eos.hpp is the correct approach for this codebase to get physical constants in the right unit system.
DavidFang03
commented
Dec 8, 2025
DavidFang03
commented
Dec 9, 2025
DavidFang03
force-pushed
the
eos_fermi
branch
from
2cbc654 to
bb4d122
Compare
Workflow reportworkflow report corresponding to commit 954edd8 Light CI is enabled. This will only run the basic tests and not the full tests. Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Doxygen diff with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fermi gas:
Usage:
where
mu_eis the molecular weightHowever I need to get the constants with the right units, how can I do that in eos.hpp ?