Added ARGUMENT_LABEL property to expressions#1836
Merged
max-leuthaeuser merged 3 commits intomasterfrom Feb 6, 2026
Merged
Conversation
maltek
reviewed
Feb 6, 2026
Comment on lines
+59
to
+63
| |This field is used to keep track of the argument label for languages that support them, such as Swift. | ||
| |It is used in addition to `ARGUMENT_INDEX` and can be used to reconstruct the original call syntax more faithfully. | ||
| |For example, in Swift, a method call may look like `foo(arg1: 42, arg2: "hello")` where `arg1` and `arg2` | ||
| |are argument labels. In this case, the `ARGUMENT_LABEL` field for the first argument would be set to `arg1` | ||
| |and for the second argument it would be set to `arg2`. |
Contributor
There was a problem hiding this comment.
explicitly state here the difference to ARGUMENT_NAME: for dataflow purposes the name should be an exact match of the NAME of a METHOD_PARAMETER_{IN,OUT} and overrides ARGUMENT_INDEX for dataflow purposes. Whereas the label should not be expected to match the name of any parameter, and is not needed for dataflow purposes at all.
maltek
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.