Fix how app name is set from the AppLoader #6561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plvaldes
force-pushed
the
11-03-fix_how_app_name_is_set_from_the_apploader
branch
4 times, most recently
from
82771ed to
b0bc6ac
Compare
Contributor
Coverage report
Show files with reduced coverage 🔻
Test suite run success3353 tests passing in 1372 suites. Report generated by 🧪jest coverage report action from 64d1fc7 |
plvaldes
force-pushed
the
11-03-fix_how_app_name_is_set_from_the_apploader
branch
from
b0bc6ac to
802d390
Compare
plvaldes
commented
Nov 4, 2025
| } | ||
|
|
||
| const appConfiguration = ` | ||
| name = "my_app" |
Contributor
Author
There was a problem hiding this comment.
Many changes in the test files are like this one: name is now required in test fixtures to be able to load the app
plvaldes
commented
Nov 4, 2025
| } | ||
| } | ||
|
|
||
| export async function loadAppName(appDirectory: string): Promise<string> { |
Contributor
Author
There was a problem hiding this comment.
We will always have at least a name, so we don't need this fallback. Thus, this is dead code
plvaldes
force-pushed
the
11-03-fix_how_app_name_is_set_from_the_apploader
branch
6 times, most recently
from
f0f51bc to
5b2d4f9
Compare
This comment has been minimized.
This comment has been minimized.
plvaldes
force-pushed
the
11-03-fix_how_app_name_is_set_from_the_apploader
branch
from
5b2d4f9 to
48aad4e
Compare
plvaldes
force-pushed
the
11-03-fix_how_app_name_is_set_from_the_apploader
branch
from
48aad4e to
64d1fc7
Compare
gonzaloriestra
approved these changes
Nov 4, 2025
gonzaloriestra
deleted the
11-03-fix_how_app_name_is_set_from_the_apploader
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/shop/issues-develop/issues/21234
The CLI was sending the package.json name as the app version name on
shopify app deploy, which was creating some confusion to usersWHAT is this pull request doing?
This PR changes the way the app version name is set and now follows these rules:
handlefrom the TOML file is usedhandle, thenameis used as a fallbackHow to test your changes?
shopify app deployand check that this handle is the prefix for the app version name (see the output from the command)Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist