Skip to content

Conversation

@gonzaloriestra
Copy link
Contributor

WHY are these changes introduced?

After https://github.com/shop/world/pull/256406, dev up is raising this error:

You must specify at least one node package if the `packages:` section is present.

WHAT is this pull request doing?

Removes the packages field under node in dev.yml, which is unneeded.

How to test your changes?

dev up

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@gonzaloriestra gonzaloriestra marked this pull request as ready for review November 3, 2025 15:15
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner November 3, 2025 15:15
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.21% (+0.01% 🔼)
13539/17093
🟡 Branches
73.08% (+0.02% 🔼)
6610/9045
🟡 Functions 79.31% 3488/4398
🟡 Lines
79.57% (+0.01% 🔼)
12791/16075

Test suite run success

3334 tests passing in 1369 suites.

Report generated by 🧪jest coverage report action from f5c8d46

@gonzaloriestra gonzaloriestra added this pull request to the merge queue Nov 3, 2025
Merged via the queue into main with commit b4ad9dd Nov 3, 2025
29 checks passed
@gonzaloriestra gonzaloriestra deleted the fix-dev-packages branch November 3, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants