Skip to content

Guard extension points being undefined #6564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoviDeCroock merged 2 commits into from
Nov 3, 2025
Merged

Guard extension points being undefined #6564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57b727f
Guard extension points being undefined
JoviDeCroock Nov 3, 2025
c251710
Add changeset
JoviDeCroock Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/great-scissors-dance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/app': patch
---

Guard against extension_points being omitted from config
11 changes: 7 additions & 4 deletions packages/app/src/cli/models/extensions/specifications/ui_extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ const uiExtensionSpec = createExtensionSpecification({
return validateUIExtensionPointConfig(directory, config.extension_points, path)
},
deployConfig: async (config, directory) => {
const transformedExtensionPoints = config.extension_points.map(addDistPathToAssets)
const transformedExtensionPoints = config.extension_points?.map(addDistPathToAssets) ?? []

return {
api_version: config.api_version,
Expand All @@ -105,7 +105,10 @@ const uiExtensionSpec = createExtensionSpecification({
},
getBundleExtensionStdinContent: (config) => {
const shouldIncludeShopifyExtend = isRemoteDomExtension(config)
const main = config.extension_points

const extensionPoints = config.extension_points || []

const main = extensionPoints
.map(({target, module}, index) => {
if (shouldIncludeShopifyExtend) {
return `import Target_${index} from '${module}';shopify.extend('${target}', (...args) => Target_${index}(...args));`
Expand All @@ -115,7 +118,7 @@ const uiExtensionSpec = createExtensionSpecification({
.join('\n')

const assets: {[key: string]: Asset} = {}
config.extension_points.forEach((extensionPoint) => {
extensionPoints.forEach((extensionPoint) => {
// Start of Selection
Object.entries(extensionPoint.build_manifest.assets).forEach(([identifier, asset]) => {
if (identifier === AssetIdentifier.Main) {
Expand All @@ -142,7 +145,7 @@ const uiExtensionSpec = createExtensionSpecification({
},
hasExtensionPointTarget: (config, requestedTarget) => {
return (
config.extension_points.find((extensionPoint) => {
config.extension_points?.find((extensionPoint) => {
return extensionPoint.target === requestedTarget
}) !== undefined
)
Expand Down