Skip to content

Upgrade tmp and cucumber #6568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gonzaloriestra merged 4 commits into from
Nov 4, 2025
Merged

Upgrade tmp and cucumber #6568

gonzaloriestra merged 4 commits into from
Nov 4, 2025

Conversation

@gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Nov 4, 2025 •
edited
Loading

WHY are these changes introduced?

Fixes https://github.com/Shopify/cli/security/dependabot/175

WHAT is this pull request doing?

Upgrades tmp to solve the vulnerability. The cucumber upgrade is required for that.

How to test your changes?

CI

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements
79.23% (-0.01% 🔻)
 13565/17120
🟡 Branches 73.08% 6620/9059
🟡 Functions
79.36% (-0.02% 🔻)
 3498/4408
🟡 Lines 79.59% 12811/16096
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟢
... / Dev.tsx
90.59% (-2.35% 🔻)
75% (-1.79% 🔻)
86.36% (-4.55% 🔻)
92.5% (-1.25% 🔻)

Test suite run success

3351 tests passing in 1372 suites.

Report generated by 🧪jest coverage report action from b80bffb

@gonzaloriestra gonzaloriestra marked this pull request as ready for review November 4, 2025 09:41
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner November 4, 2025 09:41
@gonzaloriestra gonzaloriestra added this pull request to the merge queue Nov 4, 2025
Merged via the queue into main with commit 0480194 Nov 4, 2025
28 checks passed
@gonzaloriestra gonzaloriestra deleted the upgrade-tmp-cucumber branch November 4, 2025 10:15
@gonzaloriestra gonzaloriestra mentioned this pull request Nov 4, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isaacroldan isaacroldan isaacroldan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gonzaloriestra @isaacroldan