Skip to content

Conversation

@shauns
Copy link
Contributor

@shauns shauns commented Nov 21, 2025

WHY are these changes introduced?

To enhance the flexibility of the renderTasks/Tasks component by allowing it to accept TokenizedString objects as task titles, not just plain strings. This lets us highlight parts of the title.

Copy link
Contributor Author

shauns commented Nov 21, 2025

@github-actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.22% 13662/17246
🟡 Branches 73.11% 6656/9104
🟡 Functions 79.36% 3521/4437
🟡 Lines 79.58% 12905/16217

Test suite run success

3375 tests passing in 1383 suites.

Report generated by 🧪jest coverage report action from 4d6099e

@shauns shauns force-pushed the shauns/add-admin-as-app-auth branch from 9dc2eb8 to 8d6a6a3 Compare November 21, 2025 13:04
@shauns shauns force-pushed the shauns/tasks-tokenized-title branch from ec968cf to 4d6099e Compare November 21, 2025 13:04
@github-actions
Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/session.d.ts
@@ -122,4 +122,15 @@ export declare function ensureAuthenticatedBusinessPlatform(scopes?: BusinessPla
  * @returns A promise that resolves when the logout is complete.
  */
 export declare function logout(): Promise<void>;
+/**
+ * Ensure that we have a valid Admin session for the given store, with access on behalf of the app.
+ *
+ * See  for access on behalf of a user.
+ *
+ * @param storeFqdn - Store fqdn to request auth for.
+ * @param clientId - Client ID of the app.
+ * @param clientSecret - Client secret of the app.
+ * @returns The access token for the Admin API.
+ */
+export declare function ensureAuthenticatedAdminAsApp(storeFqdn: string, clientId: string, clientSecret: string): Promise<AdminSession>;
 export {};
\ No newline at end of file
packages/cli-kit/dist/private/node/ui/components/Tasks.d.ts
@@ -1,7 +1,8 @@
 import { AbortSignal } from '../../../../public/node/abort.js';
+import { TokenizedString } from '../../../../public/node/output.js';
 import React from 'react';
 export interface Task<TContext = unknown> {
-    title: string;
+    title: string | TokenizedString;
     task: (ctx: TContext, task: Task<TContext>) => Promise<void | Task<TContext>[]>;
     retry?: number;
     retryCount?: number;

Base automatically changed from shauns/add-admin-as-app-auth to main November 21, 2025 14:47
@shauns shauns added this pull request to the merge queue Nov 21, 2025
Merged via the queue into main with commit 1ce00c5 Nov 21, 2025
25 of 45 checks passed
@shauns shauns deleted the shauns/tasks-tokenized-title branch November 21, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants