Remove unused field selections from BulkOperation GraphQL documents
#6655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
Contributor
Coverage report
Show files with reduced coverage 🔻
Test suite run success3402 tests passing in 1384 suites. Report generated by 🧪jest coverage report action from 06c9d9c |
jordanverasamy
force-pushed
the
jtv/unify-bulk-operation-type
branch
from
392829a to
c7ae63c
Compare
jordanverasamy
force-pushed
the
jtv/watch-live-progress
branch
from
c9b42e0 to
5270287
Compare
Contributor
|
This looks great. Thanks for doing this! |
ericlee878
approved these changes
Nov 22, 2025
jordanverasamy
force-pushed
the
jtv/unify-bulk-operation-type
branch
from
c7ae63c to
f13e8d5
Compare
jordanverasamy
force-pushed
the
jtv/watch-live-progress
branch
from
5270287 to
d3ffc48
Compare
isaacroldan
approved these changes
Nov 25, 2025
gonzaloriestra
approved these changes
Nov 25, 2025
jordanverasamy
changed the base branch from
jtv/watch-live-progress
to
graphite-base/6655
This was referenced Nov 25, 2025
jordanverasamy
force-pushed
the
jtv/unify-bulk-operation-type
branch
from
f13e8d5 to
abc93e2
Compare
jordanverasamy
force-pushed
the
graphite-base/6655
branch
from
d3ffc48 to
c8e62d6
Compare
jordanverasamy
changed the base branch from
graphite-base/6655
to
jtv/watch-live-progress
jordanverasamy
force-pushed
the
jtv/unify-bulk-operation-type
branch
from
abc93e2 to
06c9d9c
Compare
jordanverasamy
force-pushed
the
jtv/watch-live-progress
branch
from
c8e62d6 to
4c19852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjacent to https://github.com/shop/issues-api-foundations/issues/1093, but not directly related.
WHY are these changes introduced?
I noticed while working on #6595 that we are asking for fields that we don't use in some of our GraphQL mutations. I want us to follow GraphQL best practices so I'm cleaning that up :)
WHAT is this pull request doing?
Clean up the field selections of
bulkOperationRunMutationandbulkOperationRunQuery, so that we don't ask for any fields that we won't actually use.How to test your changes?
All tests pass and all tophat steps from #6595 still work.