Fix Promise.withResolvers TypeScript signature conflict #6746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove optional modifier from withResolvers global declaration to match native Node 24 signature. The optional modifier causes TypeScript to error with "Overload signatures must all be optional or required" when compiling against Node 24's built-in types. This was introduced in PR #6740 which added the global declaration but incorrectly marked it as optional, conflicting with the required signature in Node 24's lib.d.ts. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3586 tests passing in 1420 suites. Report generated by 🧪jest coverage report action from 85d2fff |
Contributor
Author
|
HAHA jk no bug i'm just a goober. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#6740 introduced a global declaration for
Promise.withResolvers(this line) but incorrectly marked it as optional with?. this conflicts with node 24's native type definition which marks it as required, causing typescript to error:this PR fixes it by removing that optional modifier in the global
PromiseConstructorinterface declaration.Test plan
pnpm nx run theme:type-checkpassespnpm refresh-manifestscompletes successfully