Abstract build steps to externalize the build configuration#6842
Draft
alfonso-noriega wants to merge 1 commit intoproj-48450/asset-pipeline-for-hosted-appsfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5 tasks
Contributor
Coverage report
Test suite run success3777 tests passing in 1461 suites. Report generated by 🧪jest coverage report action from cf3d1cc |
cf3d1cc to
fab204c
Compare
4dd73b7 to
4a80cd2
Compare
fab204c to
602145f
Compare
4a80cd2 to
510502e
Compare
602145f to
bfb2090
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

[Feature] Add build_steps extension build mode for flexible build pipelines
WHY are these changes introduced?
This PR introduces a new
build_stepsbuild mode for extensions, providing a more flexible and configurable build pipeline system. This allows extension developers to define custom build steps with different strategies, rather than being limited to the existing predefined build modes.WHAT is this pull request doing?
build_stepsmode to the extension build configurationdirectory: Copy an entire directorypattern: Copy files matching glob patternsfiles: Copy a specific list of filesThe architecture follows a Command Pattern approach, where each step type has a dedicated executor, making it easy to add more step types in the future.
How to test your changes?
shopify app devand verify that the assets are correctly copied to the output directoryMeasuring impact
How do we know this change was effective? Please choose one:
Checklist