Open
Conversation
Contributor
Coverage report
Test suite run success3772 tests passing in 1453 suites. Report generated by 🧪jest coverage report action from 34ac466 |
91704ab to
59f64fb
Compare
ad08b61 to
530c96f
Compare
530c96f to
da3a512
Compare
59f64fb to
7394674
Compare
c1df39a to
daf24cb
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/fs.d.ts@@ -1,6 +1,6 @@
import { RandomNameFamily } from '../common/string.js';
import { OverloadParameters } from '../../private/common/ts/overloaded-parameters.js';
-import { findUp as internalFindUp } from 'find-up';
+import { findUp as internalFindUp, findUpSync as internalFindUpSync } from 'find-up';
import { ReadStream, WriteStream } from 'fs';
import type { Pattern, Options as GlobOptions } from 'fast-glob';
/**
@@ -335,6 +335,7 @@ export declare function defaultEOL(): EOL;
* @returns The first path found that matches or if none could be found.
*/
export declare function findPathUp(matcher: OverloadParameters<typeof internalFindUp>[0], options: OverloadParameters<typeof internalFindUp>[1]): ReturnType<typeof internalFindUp>;
+export declare function findPathUpSync(matcher: OverloadParameters<typeof internalFindUp>[0], options: OverloadParameters<typeof internalFindUp>[1]): ReturnType<typeof internalFindUpSync>;
export interface MatchGlobOptions {
matchBase: boolean;
noglobstar: boolean;
packages/cli-kit/dist/public/node/version.d.ts@@ -1,3 +1,17 @@
+/**
+ * Returns the current CLI version, read from the nearest package.json.
+ * The result is cached after the first call.
+ *
+ * This is a lazy function (rather than a top-level constant) because
+ * depends on npm packages that may not yet be initialized during ESM module evaluation
+ * when circular imports are involved. Deferring the call to runtime avoids that issue.
+ *
+ * In unbundled (dev) mode this finds cli-kit's own package.json.
+ * In bundled (global install) mode this finds the CLI's package.json, which shares the same version.
+ *
+ * @returns The CLI version string.
+ */
+export declare function cliVersion(): string;
/**
* Returns the version of the local dependency of the CLI if it's installed in the provided directory.
*
|
daf24cb to
461b5d4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
461b5d4 to
6688cff
Compare
This comment was marked as outdated.
This comment was marked as outdated.
6688cff to
069f540
Compare
069f540 to
34ac466
Compare
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260217105009Caution After installing, validate the version by running just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
The
shopify versioncommand was returning a wrong value (the current from the main branch, like3.90.0) for snapshot releases generated with/snapitWHAT is this pull request doing?
Ensure the script to update the CLI version constant in cli-kit is run as part of the bundle task
How to test your changes?
npm i -g @shopify/cli@0.0.0-snapshot-20260217105009shopify versionMeasuring impact
How do we know this change was effective? Please choose one:
Checklist