Rename migration files when renaming migration class#690
Open
sucicfilip wants to merge 1 commit intoShopify:mainfrom
Open
Rename migration files when renaming migration class#690sucicfilip wants to merge 1 commit intoShopify:mainfrom
sucicfilip wants to merge 1 commit intoShopify:mainfrom
Conversation
sucicfilip
force-pushed
the
feature/rename-migration-files
branch
from
3076af5 to
7428f4a
Compare
Author
|
After testing this on a bigger codebase, I think it would be better to implement it like the "Run migrations" pop up, because currently it is quite slow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically rename migration files when renaming the migration class via
textDocument/rename.For example, renaming
CreateFoostoCreateBarswill also rename20210901000000_create_foos.rbto20210901000000_create_bars.rb.Depends on Shopify/ruby-lsp#3958 which adds the collect_file_renames addon hook.
Closes #497