Skip to content

Conversation

@vinistock
Copy link
Member

@vinistock vinistock commented Mar 8, 2023

Motivation

We should make sure the Ruby LSP also works with TruffleRuby.

@vinistock vinistock requested a review from a team as a code owner March 8, 2023 19:00
@vinistock vinistock self-assigned this Mar 8, 2023
@Shopify Shopify deleted a comment from github-actions bot Mar 8, 2023
@Shopify Shopify deleted a comment from github-actions bot Mar 8, 2023
@Shopify Shopify deleted a comment from github-actions bot Mar 8, 2023
@Shopify Shopify deleted a comment from github-actions bot Mar 8, 2023
@vinistock vinistock force-pushed the vs/test_against_truffle_and_jruby branch 2 times, most recently from b119b85 to f529ddb Compare March 9, 2023 19:28
@vinistock
Copy link
Member Author

JRuby

JRuby is failing on a test and it seems like a bug (maybe in JRuby's Ripper implementation?). In MRI, SyntaxTree::Parser#on_params receives optionals as an array of SyntaxTree::Ident, but in JRuby we receive an array of SyntaxTree::VarRef.

TruffleRuby

The integration tests seem to be hanging. Still investigating why.

@vinistock vinistock force-pushed the vs/test_against_truffle_and_jruby branch from f529ddb to fee66c4 Compare April 11, 2023 20:04
@Shopify Shopify deleted a comment from github-actions bot Apr 11, 2023
@Shopify Shopify deleted a comment from github-actions bot Apr 11, 2023
@Shopify Shopify deleted a comment from github-actions bot Apr 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2023

Benchmark results in seconds (slowest at top)

          textDocument/completion average: 0.262625 std_dev: 0.004946
          textDocument/diagnostic average: 0.038287 std_dev: 0.009206
      textDocument/selectionRange average: 0.003209 std_dev: 0.000396
   textDocument/documentHighlight average: 0.001649 std_dev: 9.1e-05
      textDocument/documentSymbol average: 0.001643 std_dev: 9.2e-05
 textDocument/semanticTokens/full average: 0.00164 std_dev: 0.000265
            textDocument/codeLens average: 0.001635 std_dev: 0.000115
        textDocument/documentLink average: 0.001634 std_dev: 9.9e-05
        textDocument/foldingRange average: 0.001446 std_dev: 8.5e-05
textDocument/semanticTokens/range average: 0.000824 std_dev: 4.5e-05
           textDocument/inlayHint average: 0.00058 std_dev: 2.9e-05
               codeAction/resolve average: 0.00056 std_dev: 6.2e-05
               textDocument/hover average: 0.000523 std_dev: 5.5e-05
          textDocument/formatting average: 6.0e-05 std_dev: 0.00029
    textDocument/onTypeFormatting average: 5.9e-05 std_dev: 4.1e-05
          textDocument/codeAction average: 3.4e-05 std_dev: 2.7e-05


================================================================================
Comparison with main branch:

 textDocument/semanticTokens/full unchanged
textDocument/semanticTokens/range unchanged
      textDocument/documentSymbol unchanged
        textDocument/foldingRange unchanged
          textDocument/formatting unchanged
          textDocument/diagnostic unchanged
        textDocument/documentLink unchanged
           textDocument/inlayHint unchanged
      textDocument/selectionRange unchanged
   textDocument/documentHighlight unchanged
               textDocument/hover unchanged
          textDocument/codeAction unchanged
    textDocument/onTypeFormatting unchanged
               codeAction/resolve unchanged
          textDocument/completion unchanged
            textDocument/codeLens unchanged

@st0012 st0012 force-pushed the vs/test_against_truffle_and_jruby branch from fee66c4 to 071ba56 Compare June 22, 2023 18:56
@st0012 st0012 changed the title Test against JRuby and TruffleRuby Test against TruffleRuby Jun 22, 2023
@st0012 st0012 force-pushed the vs/test_against_truffle_and_jruby branch 2 times, most recently from 20ecc09 to 1e111d6 Compare June 22, 2023 19:13
Co-authored-by: Vinicius Stock <vinicius.stock@shopify.com>
@st0012 st0012 force-pushed the vs/test_against_truffle_and_jruby branch from ee28d03 to ae9aa8b Compare June 27, 2023 15:15
@st0012 st0012 force-pushed the vs/test_against_truffle_and_jruby branch from ae9aa8b to b97b566 Compare June 27, 2023 15:33
@github-actions
Copy link
Contributor

This pull request is being marked as stale because there was no activity in the last 2 months

@github-actions github-actions bot added the Stale label Aug 27, 2023
@vinistock
Copy link
Member Author

Closing this for now. We'll need to do another attempt to get TruffleRuby and JRuby in our CI.

@vinistock vinistock closed this Aug 28, 2023
@vinistock vinistock deleted the vs/test_against_truffle_and_jruby branch August 28, 2023 13:33
vinistock pushed a commit that referenced this pull request Feb 28, 2024
@andyw8 andyw8 restored the vs/test_against_truffle_and_jruby branch November 25, 2024 16:49
@vinistock vinistock deleted the vs/test_against_truffle_and_jruby branch March 20, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants