Delegate save to saviour proc #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: lib/stackprof/middleware.rb test/test_middleware.rb
Signed-off-by: Simon Eskildsen <sirup@sirupsen.com>
middleware: allow raw dumps
ensure raw is present in joined output
bump flamegraph script
Bump to 0.2.9
| filename ||= "stackprof-#{results[:mode]}-#{Process.pid}-#{Time.now.to_i}.dump" | ||
| File.open(File.join(Middleware.path, filename), 'wb') do |f| | ||
| f.write Marshal.dump(results) | ||
| if saviour.respond_to?(:call) |
Member
Author
There was a problem hiding this comment.
We should just assume saviour is callable if non-nil, so if saviour here.
|
👍 for the name saviour, for starters. |
test/test_middleware.rb
Outdated
| proc_called = false | ||
| env_set = nil | ||
| results_received = nil | ||
| middleware = StackProf::Middleware.new(proc {|env| proc_called = true}, enabled: Proc.new{ [true, 'foo'] }, saviour: Proc.new{ |env, results| env_set = env['FOO'] ; results_received = results[:mode] }, save_every: 1) |
Member
Author
There was a problem hiding this comment.
OMG - can we split this line?
Member
Author
There was a problem hiding this comment.
When can we call proc {|arg| ... } vs. Proc.new {|arg| ...}?
| proc_called = false | ||
| env_set = nil | ||
| results_received = nil | ||
| enable_proc = Proc.new{ [true, 'foo'] } |
Member
Author
There was a problem hiding this comment.
enable_proc = proc{ [true, 'foo'] }?
Member
Author
There was a problem hiding this comment.
I realize I want to just replace all Proc.new calls with proc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
Middleware.saviourhook to allow overriding the save mechanism. In our case, we want to push theStackProf.resultsto Kafka.r: @shivnagarajan