Make max collateral a multiplier #880
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| CollateralMultiplier: 2.0, // 2x storage price | ||
| MaxCollateral: types.Siacoins(1000), | ||
| CollateralMultiplier: 2.0, // 2x storage price | ||
| MaxCollateralMultiplier: 10.0, // 10x collateral |
Member
There was a problem hiding this comment.
Doesn't making this a multiplier effectively remove the max? I'm not sure how you'd apply it in the validation code.
e.g. a host offers 1H / byte / month then the max becomes 10H / byte / month. But what does that even mean?
In my head that would only work if the multiplier was not just a multiplier but the actual storage you expect a renter to be able to store in a contract. Like 10 * 1<<40 and then the max is 10TB of collateral / month.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version is draft because it will currently fail RHP4 tests because it treats max collateral as a TB/byte/block like storage price and collateral instead of as a fixed absolute value. If we want to continue down this path, we will need to similarly change the RHP4 validation and bump the protocol version.
Alternatively, we can calculate the actual max collateral value as described in the issue and assume
max contract duration.Fixes #857