Refactor wallet tests #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR refactors wallet tests to reduce boilerplate code by introducing a testNode helper struct and newTestNode function. The refactoring improves test maintainability by consolidating common setup logic for test nodes that include consensus chain, store, and wallet manager initialization.
Key Changes:
- Introduced
testNodestruct andnewTestNodehelper function to encapsulate test node setup - Added import alias
ctestutilforgo.sia.tech/coreutils/testutilto avoid naming conflict with internaltestutilpackage - Replaced repetitive test setup code across 18+ test functions with the new helper
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| wallet/wallet_test.go | Added testNode struct and newTestNode helper; refactored 18 test functions to use the new helper; replaced direct testutil.MineBlocks calls with ctestutil.MineBlocks |
| wallet/manager_test.go | Refactored TestHealth to use newTestNode helper and removed redundant setup code |
| wallet/addresses_test.go | Refactored 4 test functions and 1 benchmark to use newTestNode helper, eliminating duplicated setup code |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chris124567
requested review from
ChrisSchinnerl,
alexfreska,
n8mgr and
peterjan
peterjan
approved these changes
Jan 5, 2026
ChrisSchinnerl
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #133