IOT_DS-8449 Refactor code convention check #60
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2474189c00
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [submodule ".github/coding-convention-tool"] | ||
| path = .github/coding-convention-tool | ||
| url = https://github.com/SiliconLabsSoftware/devs-coding-convention-tool.git |
There was a problem hiding this comment.
The commit removes the .github/coding-convention-tool submodule, but the CI workflow still references files inside that directory (e.g., .github/workflows/00-Check-Code-Convention.yml:60–66 copies ./.github/coding-convention-tool/tools/uncrustify/uncrustify.cfg and uses .github/coding-convention-tool/.pre-commit-config.yaml). When that workflow runs, those paths will no longer exist and the job will fail before any checks run. If the intent is to remove the tool, the workflow should be updated to avoid those paths or point to a replacement.
Useful? React with 👍 / 👎.
|
Code convention workflow now uses github composite action
AndrasZiegler
changed the title
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73f5e9b279
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| uses: SiliconLabsSoftware/devs-coding-convention-tool@master | ||
| with: | ||
| custom-exclude-file: "" | ||
| custom-ignore-words: ".github/formatting_config/ignore-words.txt" |
There was a problem hiding this comment.
The workflow now passes custom-ignore-words as .github/formatting_config/ignore-words.txt, but that path does not exist anywhere in this repository (there is no .github/formatting_config directory or ignore-words.txt file). If the action attempts to read the file when a non-empty path is provided, the job will error out; consider adding the file or removing the input.
Useful? React with 👍 / 👎.
Description
Related Issue
Closes #<issue_number>
Changes Made
Checklist
Screenshots (if applicable)
Additional Notes