Created composite workflow #7
Conversation
|
@codex review |
There was a problem hiding this comment.
Pull request overview
This PR introduces a GitHub Actions composite action for automated code convention checking. The action detects the runner environment (self-hosted or GitHub-hosted), installs required tools (Python, pre-commit, uncrustify, clang-tidy), and runs pre-commit checks to validate code against configured standards.
Changes:
- Created a composite action that validates code conventions using pre-commit hooks
- Added automatic runner type detection with manual override capability
- Implemented artifact uploads for both results and code fix patches
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b16e4fffd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
AndrasZiegler
force-pushed
the
IOT_DS-8449-create-composite-workflow
branch
from
2347ebe to
fa240bf
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa240bf60d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Created Dockerfile with default entrypoint.sh to run pre-commit hooks Created the action.yml Updated the README.md with usage instructions
AndrasZiegler
force-pushed
the
IOT_DS-8449-create-composite-workflow
branch
from
fa240bf to
ff6fd84
Compare
AndrasZiegler
force-pushed
the
IOT_DS-8449-create-composite-workflow
branch
from
86efa6c to
9940c6c
Compare
| description: "Check code conventions using Docker container" | ||
|
|
||
| inputs: | ||
| custom-exclude-file: |
There was a problem hiding this comment.
This exclude file is the deceptive exclude file of the coding convention?
Because that is basically useless, would be much better to have an actual exclude with regex/glob.
(The other option is the custom pre-commit config which is not really nice.)
| # Or copy & paste the whole problematic line to 'exclude-file.txt' | ||
| ignore-words = ./.github/coding-convention-tool/tools/.codespell/ignore-words.txt | ||
| exclude-file = ./.github/coding-convention-tool/tools/.codespell/exclude-file.txt | ||
| ignore-words = /action/tools/.codespell/ignore-words.txt |
There was a problem hiding this comment.
there is no action folder in the repo.
Is this some GH magic?
If yes, then would be nice to mention it somewhere.
2 participants
Description
Related Issue
Closes #<issue_number>
Changes Made
Checklist
Screenshots (if applicable)
Additional Notes