Open
Conversation
RClone specifies `0` not `0s` to disable timeouts
Correct idle_timeout setting
There was a problem hiding this comment.
Pull Request Overview
This pull request improves the rclone mount systemd service and configuration templates to address timeout issues and enhance service reliability. The changes focus on log file management, mount options for symbolic links, service restart behavior, and configuration consistency.
- Added log file size limiting and symbolic link support to the mount service
- Changed service restart policy from
on-aborttoon-failurefor better error handling - Updated configuration template to use numeric timeout value instead of string format
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| includes/rclone/rclone-template.conf | Updated idle_timeout from "0s" to "0" for consistency |
| includes/rclone/rclone-mount-template.service | Added log size limit, symbolic link support, and improved restart policy |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several improvements to the rclone mount systemd service template and rclone configuration template. The changes focus on log management, mount options, service reliability, and configuration consistency.
Service template improvements:
--log-file-max-size 5Mto limit the size of rclone log files, helping to prevent disk space issues.--vfs-linksto the mount options to enable support for symbolic links in the mounted remote.Restart=on-aborttoRestart=on-failurefor improved reliability in case of errors.Configuration template update:
idle_timeoutfrom0sto0for improved consistency and compatibility in the rclone configuration.