-
-
Notifications
You must be signed in to change notification settings - Fork 2
Allow Multi-Platform, starting with Fabric #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
RhythmicSys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I had any code changes I saw that were needed, just general directional ideas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would eventually like to extract the commands to common, since they use brig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to move this into common along with commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would also like to move this into common, unsure if other platforms will need separate types of exceptions and handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unsure how the other platforms handle permissions, this might be able to be changed and made a common class, or converted into some sort of enum with wrappers for the different platforms
Created modules for paper and fabric platforms Paper is functional on maven package Code is not refactored to common yet, common empty
97d345e to
2502ede
Compare
Warning
This PR is incomplete and should not be merged until final code review is completed.
This PR is to enable multi-platform support for SimplePMs. It is likely we will not merge until Fabric is implemented, but this is unclear right now.
Steps