Skip to content

Conversation

@Peashooter101
Copy link
Member

@Peashooter101 Peashooter101 commented Nov 18, 2025

Warning

This PR is incomplete and should not be merged until final code review is completed.

This PR is to enable multi-platform support for SimplePMs. It is likely we will not merge until Fabric is implemented, but this is unclear right now.

Steps

  • Create module structure within Maven.
  • Move database CRUD off of Paper.
  • Move cache handling off of Paper.
  • Generalize configuration.
  • Generalize localization.
  • Generalize permissions handling.
  • Move commands, command arguments, and command exceptions (Brigadier) off of Paper.
  • Implement Fabric

@Peashooter101 Peashooter101 marked this pull request as draft November 18, 2025 17:00
Copy link
Member

@RhythmicSys RhythmicSys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I had any code changes I saw that were needed, just general directional ideas

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would eventually like to extract the commands to common, since they use brig

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to move this into common along with commands

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also like to move this into common, unsure if other platforms will need separate types of exceptions and handling

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unsure how the other platforms handle permissions, this might be able to be changed and made a common class, or converted into some sort of enum with wrappers for the different platforms

Created modules for paper and fabric platforms
Paper is functional on maven package
Code is not refactored to common yet, common empty
@Peashooter101 Peashooter101 force-pushed the dev/main/expand_to_mods branch from 97d345e to 2502ede Compare November 20, 2025 04:40
@Peashooter101 Peashooter101 marked this pull request as ready for review November 20, 2025 04:42
@Peashooter101 Peashooter101 marked this pull request as draft November 20, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants