fix: make split recommendation based on module relationships #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NFR Tests ✅ 39 unchangedComparing PR against main branch (dynamic baseline). Regressions: 0 ✅ Thresholds: WARN ≥ +5% • FAIL ≥ +10% All scenarios
* = new scenario, compared against static baseline |
🟢 Change Impact Analysis
Blast Radius: 0 modules, 1 files, 13 unique callers 📝 Changed Symbols (15)
🎯 Affected Downstream (13)
Generated by CKB |
🔐 Security Audit Results
📦 Dependency VulnerabilitiesFound 7 vulnerability(ies) across 2 scanner(s) DetailsTrivy (4 findings)
OSV-Scanner (3 findings)
📜 License IssuesFound 119 non-permissive license(s) Details
Generated by CKB Security Audit | View Details | Security Tab |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.0%) is below the target coverage (30.0%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
=======================================
- Coverage 45.1% 45.1% -0.1%
=======================================
Files 350 350
Lines 59739 59747 +8
=======================================
Hits 26961 26961
- Misses 30952 30960 +8
Partials 1826 1826
Flags with carried forward coverage won't be shown. Click here to find out more. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
CKB Analysis
Risk factors: Touches 1 hotspot(s)
🎯 Change Impact Analysis · 🟢 LOW · 15 changed → 13 affected
Symbols changed in this PR:
Downstream symbols affected:
🔥 Hotspots · 1 volatile files
📊 Complexity · 1 violations
💡 Quick wins · 10 suggestions
📚 Stale docs · 143 broken references
Generated by CKB · Run details |
…bol count Previously, the change impact analysis recommended splitting PRs based solely on symbol count (>15). This was not useful - a cohesive feature adding many symbols to one module shouldn't be split. Now the split recommendation triggers only when: 1. Changes touch 2+ files (single file = cohesive by definition) 2. Impact affects 3+ distinct modules (suggesting broad changes) This ensures single-file PRs never get split recommendations, and multi-file PRs only get them when impact is truly widespread. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
SimplyLiz
force-pushed
the
fix/smart-split-recommendation
branch
from
b60bf62 to
5112e36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
hasUnrelatedModuleChanges()to detect when changes span disconnected modulesRationale
A cohesive feature adding 50 symbols to one module shouldn't trigger a split recommendation, but unrelated changes across disconnected modules should.
Test plan
go build ./cmd/ckbpassesgo test ./internal/query/...passes🤖 Generated with Claude Code