-
-
Notifications
You must be signed in to change notification settings - Fork 416
Update Fields and cleanup BukkitClasses #8300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
APickledWalrus
merged 5 commits into
SkriptLang:dev/feature
from
TheLimeGlass:feature/fields-update
Jan 1, 2026
Merged
Update Fields and cleanup BukkitClasses #8300
APickledWalrus
merged 5 commits into
SkriptLang:dev/feature
from
TheLimeGlass:feature/fields-update
Jan 1, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
requested changes
Nov 28, 2025
Member
sovdeeth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
sovdeeth
approved these changes
Nov 28, 2025
erenkarakal
approved these changes
Dec 16, 2025
APickledWalrus
approved these changes
Dec 22, 2025
Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
completed
The issue has been fully resolved and the change will be in the next Skript update.
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds short hand methods for singleton
Fieldsobjects, aswell as removing the forced Serializer deserialize method wheninstantiated == false, when canBeInstantiated is majority of the time returned false, and even if it's true, Yggdrasil will take over on primitives (See number serializers). This removes the need for defining thepublic void deserialize(Example object, Fields fields) {method.Before:
After:
Also cleaned up the formatting of BukkitClasses to be like the top 80% of the class.
There is also a new mapper method for collecting singleton objects from Fields
Before:
After:
Testing Completed
Skript tests
Other
StreamCorruptedException should be removed in the future with something like an Optional, or having the logger pickup
Skript.error. As the main usage is for error reporting. Having try catches on every serialized element is wasteful resources. This will also allow for out of scope erroring, since Functions can't throw to the origin call stack.Completes: none
Related: none