Pre Player Attack Entity

[MrScopes]

Problem

This event could be useful in some situations.
https://jd.papermc.io/paper/1.21.11/io/papermc/paper/event/player/PrePlayerAttackEntityEvent.html

Solution

Added on attempt attack and on attempt[ing] to attack %entitydatas%
Added [the] (entity|victim) (:will|will not|won't) be attack(ed|ing) decided not to include since it's effectively useless. the event is fired as canceled if the entity won't be attacked

Testing Completed

Tested my examples given. Everything works as expected

                    on attack attempt:
                        if event is cancelled:
                            broadcast "%attacker% failed to attack %victim%!"
                        else:
                            broadcast "%attacker% damaged %victim%!"

                    on attempt to attack an animal:
                        cancel event        

                    on attempting to attack an entity:
                        if victim is a creeper:
                            cancel event     

                    on attempt to attack a zombie or creeper:
                        attacker isn't holding a diamond sword
                        cancel event

Supporting Information

ExprAttacked and ExprAttacker also updated to support this event, and I also updated the code in both classes to follow new conventions

---

Completes: 8266
Related: none
AI assistance: none

[sovdeeth]

Note that listening to cancelled events does not require the config, you can simply do on cancelled X or on any X

[MrScopes]

Note that listening to cancelled events does not require the config, you can simply do on cancelled X or on any X

Good to know. I can update the examples and description with that + whatever else is decided

[Efnilite]

looks good after sovde's changes

[MrScopes]

Decided on

on attempt[ing] to attack %entitydatas%
on attack attempt

[Efnilite]

additionally you should change the target branch to dev/feature

[MrScopes]

unsure how if at all, build failure is related to my code

[Efnilite]

unsure how if at all, build failure is related to my code

the test run crashed, happens sometimes 😉