Skip to content

StringToClassRule: Add option to require strict casing #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DieterHolvoet wants to merge 1 commit into
base: master
Choose a base branch
from
Open

StringToClassRule: Add option to require strict casing #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions conf/slam-rules.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
parameters:
stringToClassRule:
strictCasing: false

parametersSchema:
stringToClassRule: structure([
strictCasing: bool()
])

services:
-
class: SlamPhpStan\ClassNotationRule
Expand All @@ -15,6 +24,8 @@ services:
class: SlamPhpStan\StringToClassRule
tags:
- phpstan.rules.rule
arguments:
strictCasing: %stringToClassRule.strictCasing%
-
class: SlamPhpStan\UnusedVariableRule
tags:
Expand Down
6 changes: 4 additions & 2 deletions lib/StringToClassRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,12 @@
final class StringToClassRule implements Rule
{
private Broker $broker;
private bool $strictCasing;

public function __construct(Broker $broker)
public function __construct(Broker $broker, bool $strictCasing)
{
$this->broker = $broker;
$this->strictCasing = $strictCasing;
}

public function getNodeType(): string
Expand All @@ -45,7 +47,7 @@ public function processNode(Node $node, Scope $scope): array
}

$classRef = $this->broker->getClass($className)->getNativeReflection();
if ($classRef->isInternal() && $classRef->getName() !== $className) {
if (($classRef->isInternal() || $this->strictCasing) && $classRef->getName() !== $className) {
return $messages;
}

Expand Down