Removing warnings

Author: jantje

it.baeyens.arduino.common/src/it/baeyens/arduino/common/Common.java

@@ -4,7 +4,6 @@
 import java.util.HashSet;
 import java.util.List;
 import java.util.Set;
-import java.util.Vector;
 
 import org.eclipse.cdt.core.CCorePlugin;
 import org.eclipse.cdt.core.envvar.EnvironmentVariable;

it.baeyens.arduino.common/src/it/baeyens/arduino/common/InstancePreferences.java

@@ -17,7 +17,8 @@
 import org.osgi.service.prefs.BackingStoreException;
 
 /**
- * ArduinoPreferences is a class containing only static methods that help managing the preferences.
+ * ArduinoPreferences is a class containing only static methods that help
+ * managing the preferences.
  * 
  * @author jan Baeyens
  * 
@@ -46,10 +47,12 @@ public static void setAutomaticallyIncludeLibraries(boolean value) {
     }
 
     /***
-     * get the stored option whether a build before the upload is wanted or not. If nothing is stored the option is ask and this method will pop up a
+     * get the stored option whether a build before the upload is wanted or not.
+     * If nothing is stored the option is ask and this method will pop up a
      * dialogbox
      * 
-     * @return true if a build is wanted before upload false if no build is wanted before upload
+     * @return true if a build is wanted before upload false if no build is
+     *         wanted before upload
      */
     public static boolean getBuildBeforeUploadOption() {
 
@@ -93,7 +96,8 @@ public void run() {
     }
 
     /**
-     * This method reads the name of the last used arduino board from the instance preferences
+     * This method reads the name of the last used arduino board from the
+     * instance preferences
      * 
      * @return the Arduino Board name
      * @author Jan Baeyens
@@ -164,7 +168,8 @@ public static void setGlobalValue(String key, String Value) {
 	try {
 	    myScope.flush();
 	} catch (BackingStoreException e) {
-	    Common.log(new Status(IStatus.WARNING, CORE_PLUGIN_ID, "failed to set global variable of type string " + key)); //$NON-NLS-1$
+	    Common.log(
+		    new Status(IStatus.WARNING, CORE_PLUGIN_ID, "failed to set global variable of type string " + key)); //$NON-NLS-1$
 	    e.printStackTrace();
 	}
     }
@@ -186,7 +191,8 @@ protected static void setGlobalValue(String key, boolean Value) {
 	try {
 	    myScope.flush();
 	} catch (BackingStoreException e) {
-	    Common.log(new Status(IStatus.WARNING, CORE_PLUGIN_ID, "failed to set global variable of type boolean " + key)); //$NON-NLS-1$
+	    Common.log(new Status(IStatus.WARNING, CORE_PLUGIN_ID,
+		    "failed to set global variable of type boolean " + key)); //$NON-NLS-1$
 	    e.printStackTrace();
 	}
     }
@@ -197,13 +203,15 @@ protected static void setGlobalValue(String key, long Value) {
 	try {
 	    myScope.flush();
 	} catch (BackingStoreException e) {
-	    Common.log(new Status(IStatus.WARNING, CORE_PLUGIN_ID, "failed to set global variable of type long " + key)); //$NON-NLS-1$
+	    Common.log(
+		    new Status(IStatus.WARNING, CORE_PLUGIN_ID, "failed to set global variable of type long " + key)); //$NON-NLS-1$
 	    e.printStackTrace();
 	}
     }
 
     /**
-     * This method returns the index of the last used line ending options are CR LF CR+LF none
+     * This method returns the index of the last used line ending options are CR
+     * LF CR+LF none
      * 
      * @return the index of the last used setting
      */
@@ -212,7 +220,8 @@ public static int GetLastUsedSerialLineEnd() {
     }
 
     /**
-     * This method returns the index of the last used line ending options are CR LF CR+LF none
+     * This method returns the index of the last used line ending options are CR
+     * LF CR+LF none
      * 
      * @return the index of the last used setting
      */
@@ -269,7 +278,8 @@ public static void setConfigured() {
     }
 
     /**
-     * This method returns boolean whether the plugin is properly configured The plugin is configured properly if a board has been installed
+     * This method returns boolean whether the plugin is properly configured The
+     * plugin is configured properly if a board has been installed
      * 
      * @return
      */
@@ -326,15 +336,17 @@ public static void setLastUsedExamples(String[] exampleNames) {
     }
 
     public static String[] getPrivateLibraryPaths() {
-	return getGlobalString(KEY_PRIVATE_LIBRARY_PATHS, Common.getDefaultPrivateLibraryPath()).split(File.pathSeparator);
+	return getGlobalString(KEY_PRIVATE_LIBRARY_PATHS, Common.getDefaultPrivateLibraryPath())
+		.split(File.pathSeparator);
     }
 
     public static void setPrivateLibraryPaths(String[] folderName) {
-	setGlobalValue(KEY_PRIVATE_LIBRARY_PATHS, String.join(File.pathSeparator, folderName)); //$NON-NLS-1$
+	setGlobalValue(KEY_PRIVATE_LIBRARY_PATHS, String.join(File.pathSeparator, folderName));
     }
 
     public static String[] getPrivateHardwarePaths() {
-	return getGlobalString(KEY_PRIVATE_HARDWARE_PATHS, Common.getDefaultPrivateHardwarePath()).split(File.pathSeparator);
+	return getGlobalString(KEY_PRIVATE_HARDWARE_PATHS, Common.getDefaultPrivateHardwarePath())
+		.split(File.pathSeparator);
     }
 
     public static void setPrivateHardwarePaths(String[] folderName) {
@@ -347,8 +359,8 @@ public static void setPrivateHardwarePaths(String[] folderName) {
      * @return a list of all the folder locations that can contain hardware
      */
     public static String[] getHardwarePaths() {
-	return (getGlobalString(KEY_PRIVATE_HARDWARE_PATHS, EMPTY_STRING) + File.pathSeparator + ConfigurationPreferences.getInstallationPath())
-		.split(File.pathSeparator);
+	return (getGlobalString(KEY_PRIVATE_HARDWARE_PATHS, EMPTY_STRING) + File.pathSeparator
+		+ ConfigurationPreferences.getInstallationPath()).split(File.pathSeparator);
     }
 
 }

it.baeyens.arduino.core/src/it/baeyens/arduino/managers/Library.java

@@ -7,7 +7,6 @@
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
-import java.util.Comparator;
 import java.util.List;
 
 import org.apache.commons.io.FileUtils;
@@ -17,8 +16,8 @@
 import org.eclipse.core.runtime.IStatus;
 import org.eclipse.core.runtime.Status;
 
-import it.baeyens.arduino.common.Const;
 import it.baeyens.arduino.common.ConfigurationPreferences;
+import it.baeyens.arduino.common.Const;
 import it.baeyens.arduino.ui.Activator;
 
 public class Library implements Comparable<Library> {
@@ -151,8 +150,8 @@ public void setChecksum(String checksum) {
     }
 
     public Path getInstallPath() {
-	return Paths.get(ConfigurationPreferences.getInstallationPath().append(Const.LIBRARY_PATH_SUFFIX).append(this.name.replace(' ', '_'))
-		.append(this.version).toString());
+	return Paths.get(ConfigurationPreferences.getInstallationPath().append(Const.LIBRARY_PATH_SUFFIX)
+		.append(this.name.replace(' ', '_')).append(this.version).toString());
     }
 
     public boolean isInstalled() {
@@ -222,7 +221,8 @@ public IStatus remove(IProgressMonitor monitor) {
 	try {
 	    FileUtils.deleteDirectory(getInstallPath().toFile());
 	} catch (IOException e) {
-	    return new Status(IStatus.ERROR, Activator.getId(), "Failed to remove folder" + getInstallPath().toString(), e); //$NON-NLS-1$
+	    return new Status(IStatus.ERROR, Activator.getId(), "Failed to remove folder" + getInstallPath().toString(), //$NON-NLS-1$
+		    e);
 	}
 
 	return Status.OK_STATUS;