Fix problem with negation in TextView/libswoc#92
Open
shukitchan wants to merge 2 commits intoSolidWallOfCode:masterfrom
Open
Fix problem with negation in TextView/libswoc#92shukitchan wants to merge 2 commits intoSolidWallOfCode:masterfrom
shukitchan wants to merge 2 commits intoSolidWallOfCode:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ABS_MIN is 9223372036854775808
intmax_t(ABS_MIN) is -9223372036854775808
negation of that is overflow for intmax_t data type with max value of 9223372036854775807
And I think that's not the intention as well.
So I need to make this change.
This is needed for the problem found in oss fuzz - https://oss-fuzz.com/testcase-detail/5196561539530752
Also as suggested in apache/trafficserver#10971, I am creating this PR.